[GitHub] [nifi] arun-prakash-fokus commented on pull request #6651: NIFI-10799 Add OIDC to Docker images for NiFi and NiFi Registry

[GitBox <gi...@apache.org>]

arun-prakash-fokus commented on PR #6651:
URL: https://github.com/apache/nifi/pull/6651#issuecomment-1350855023

   Please correct me if I am wrong, but as of v1.19.1 (of `nifi` and `nifi-registry`), the correct properties for OIDC as written in the `nifi.properties` and `nifi-registry.properties` are slightly different:
   
   `nifi.properties`
   
   ```yml
   # OpenId Connect SSO Properties #
   nifi.security.user.oidc.discovery.url=
   nifi.security.user.oidc.connect.timeout=5 secs
   nifi.security.user.oidc.read.timeout=5 secs
   nifi.security.user.oidc.client.id=
   nifi.security.user.oidc.client.secret=
   nifi.security.user.oidc.preferred.jwsalgorithm=
   nifi.security.user.oidc.additional.scopes=
   nifi.security.user.oidc.claim.identifying.user=
   nifi.security.user.oidc.fallback.claims.identifying.user=
   nifi.security.user.oidc.truststore.strategy=JDK
   ```
   
   `nifi-registry.properties`
   
   ```yml
   # OIDC #
   nifi.registry.security.user.oidc.discovery.url=
   nifi.registry.security.user.oidc.connect.timeout=
   nifi.registry.security.user.oidc.read.timeout=
   nifi.registry.security.user.oidc.client.id=
   nifi.registry.security.user.oidc.client.secret=
   nifi.registry.security.user.oidc.preferred.jwsalgorithm=
   ```
   
   notice the difference - in `nifi.properties`, the properties are prefixed: `nifi.security.user.oidc.*`while in `nifi-registry.properties`, they are prefixed with  `nifi.registry.security.user.oidc`. 
   
   However, in your files you changed
   
   for `nifi` - [nifi-docker/dockerhub/sh/update_oidc_properties.sh](https://github.com/apache/nifi/pull/6651/files#diff-7150c03e6a81253db81e02cea689d43e5b1e83a1e3f63d467fb3938416068e4e), and
   
   for `nifi-registry` - [nifi-registry/nifi-registry-core/nifi-registry-docker/dockerhub/sh/update_oidc_properties.sh](https://github.com/apache/nifi/pull/6651/files#diff-9fb32da6796428de41a2276e3e46be7eb23caeeac4e4546a1dd91cf9525a6a13)
   
   the props that you intend to change are identical. This would likely fail. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org