You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/10/07 18:29:37 UTC

svn commit: r1868090 - /pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java

Author: tilman
Date: Mon Oct  7 18:29:37 2019
New Revision: 1868090

URL: http://svn.apache.org/viewvc?rev=1868090&view=rev
Log:
PDFBOX-3017: remove double code line, use base class, rename variable

Modified:
    pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java

Modified: pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java?rev=1868090&r1=1868089&r2=1868090&view=diff
==============================================================================
--- pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java (original)
+++ pdfbox/branches/issue45/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java Mon Oct  7 18:29:37 2019
@@ -29,7 +29,6 @@ import org.bouncycastle.asn1.ASN1ObjectI
 import org.bouncycastle.asn1.ASN1OctetString;
 import org.bouncycastle.asn1.ASN1Sequence;
 import org.bouncycastle.asn1.ASN1TaggedObject;
-import org.bouncycastle.asn1.DERTaggedObject;
 import org.bouncycastle.asn1.DLSequence;
 import org.bouncycastle.asn1.x509.GeneralName;
 import org.bouncycastle.asn1.x509.X509ObjectIdentifiers;
@@ -115,15 +114,14 @@ public class CertInformationHelper
         {
             DLSequence obj = (DLSequence) objects.nextElement();
 
-            DERTaggedObject derTagged = (DERTaggedObject) obj.getObjectAt(0);
-            derTagged = (DERTaggedObject) derTagged.getObject();
-            derTagged = (DERTaggedObject) derTagged.getObject();
-            if (!(derTagged.getObject() instanceof ASN1OctetString))
+            ASN1TaggedObject taggedObject = (ASN1TaggedObject) obj.getObjectAt(0);
+            taggedObject = (ASN1TaggedObject) taggedObject.getObject();
+            if (!(taggedObject.getObject() instanceof ASN1OctetString))
             {
                 // happens with SampleSignedPDFDocument.pdf
                 continue;
             }
-            ASN1OctetString uri = (ASN1OctetString) derTagged.getObject();
+            ASN1OctetString uri = (ASN1OctetString) taggedObject.getObject();
             String url = new String(uri.getOctets());
             // TODO Check for: DistributionPoint ::= SEQUENCE (see RFC 2459), multiples can be possible.