You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Aaron T. Myers (JIRA)" <ji...@apache.org> on 2012/05/08 23:21:50 UTC
[jira] [Created] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Aaron T. Myers created HDFS-3390:
------------------------------------
Summary: DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
Key: HDFS-3390
URL: https://issues.apache.org/jira/browse/HDFS-3390
Project: Hadoop HDFS
Issue Type: Improvement
Components: hdfs client
Affects Versions: 2.0.0
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
Priority: Minor
If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3390:
-----------------------------------------
Hadoop Flags: Reviewed
+1 patch looks good.
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-3390:
------------------------------
Fix Version/s: (was: 2.0.0)
2.0.1
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3390:
---------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Status: Resolved (was: Patch Available)
Thanks a lot for the reviews, Nicholas. I've just committed this to trunk and branch-2.
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270916#comment-13270916 ]
Hadoop QA commented on HDFS-3390:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526045/HDFS-3390.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2392//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2392//console
This message is automatically generated.
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271692#comment-13271692 ]
Hudson commented on HDFS-3390:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2288 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2288/])
HDFS-3390. DFSAdmin should print full stack traces of errors when DEBUG logging is enabled. Contributed by Aaron T. Myers. (Revision 1336324)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336324
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3390:
---------------------------------
Status: Patch Available (was: Open)
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271686#comment-13271686 ]
Hudson commented on HDFS-3390:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2213 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2213/])
HDFS-3390. DFSAdmin should print full stack traces of errors when DEBUG logging is enabled. Contributed by Aaron T. Myers. (Revision 1336324)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336324
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3390:
---------------------------------
Attachment: HDFS-3390.patch
Here's a patch which addresses the issue. It catches all exceptions from DFSAdmin commands, logs the full stack trace of the exception if LOG.isDebugEnabled, and then re-throws the exception in all cases.
I tested this manually by setting HADOOP_ROOT_LOGGER=DEBUG,console and running a few invalid commands, e.g. with illegal arguments or non-HDFS URIs.
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3390:
---------------------------------
Attachment: HDFS-3390.patch
Thanks a lot for the review, Nicholas.
The reason I did it the way I did in the original patch is that the DFSAdmin code currently has multiple separate catch blocks, and thus some code would need to be repeated in each one. In the attached patch, I've assigned the exception to a variable and only printed it out in one place at the end. I'm not sure I agree that this is much clearer, but I don't feel strongly about it. If you think this is better, then that's fine by me.
I strongly suspect that the test failures are unrelated to this patch.
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271713#comment-13271713 ]
Hudson commented on HDFS-3390:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2230 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2230/])
HDFS-3390. DFSAdmin should print full stack traces of errors when DEBUG logging is enabled. Contributed by Aaron T. Myers. (Revision 1336324)
Result = ABORTED
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336324
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273224#comment-13273224 ]
Hudson commented on HDFS-3390:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1040 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/])
HDFS-3390. DFSAdmin should print full stack traces of errors when DEBUG logging is enabled. Contributed by Aaron T. Myers. (Revision 1336324)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336324
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272349#comment-13272349 ]
Hudson commented on HDFS-3390:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1075 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1075/])
HDFS-3390. DFSAdmin should print full stack traces of errors when DEBUG logging is enabled. Contributed by Aaron T. Myers. (Revision 1336324)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336324
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271048#comment-13271048 ]
Hadoop QA commented on HDFS-3390:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526090/HDFS-3390.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2394//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2394//console
This message is automatically generated.
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3390) DFSAdmin should print full stack
traces of errors when DEBUG logging is enabled
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270924#comment-13270924 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3390:
----------------------------------------------
The double try-catch makes the code hard to read. How about either
- print the debug message in individual catch block, or
- set assign the exception to a local variable and the print the debug message outside before the return?
> DFSAdmin should print full stack traces of errors when DEBUG logging is enabled
> -------------------------------------------------------------------------------
>
> Key: HDFS-3390
> URL: https://issues.apache.org/jira/browse/HDFS-3390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Attachments: HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only the exception's message is output. It would be handy for debugging if the full stack trace of the exception were output when DEBUG logging is enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira