You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/07/02 01:11:09 UTC

[GitHub] [hadoop] shvachko commented on pull request #2260: HADOOP-17028. ViewFS should initialize mounted target filesystems lazily

shvachko commented on pull request #2260:
URL: https://github.com/apache/hadoop/pull/2260#issuecomment-872643068


   Looks good generally. I checked the tests are catching previous errors.
   
   - There seems to be one last checkstyle warning.
   - Also I see you use {{import static org.junit.Assert.*;}} and {{viewfs.Constants.*;}} We should import only what is actually needed. Avoid *-imports.
   - And I found an empty line added in {{ViewFileSystem}}. Don't know why checkstyle didn't catch it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org