[GitHub] [fineract] reluxa commented on a diff in pull request #3252: fix(build): make logging warnings clearer

["reluxa (via GitHub)" <gi...@apache.org>]

reluxa commented on code in PR #3252:
URL: https://github.com/apache/fineract/pull/3252#discussion_r1244230608


##########
buildSrc/src/main/groovy/org/apache/fineract/gradle/service/GpgService.groovy:
##########
@@ -87,7 +87,7 @@ class GpgService {
                 this.privateKey = secretKey.extractPrivateKey(new JcePBESecretKeyDecryptorBuilder().setProvider(BouncyCastleProvider.PROVIDER_NAME).build(config.password.toCharArray()))
             }
         } else {
-            log.warn("Could not open the public key ring.")
+            log.warn("WARN: If preparing a fineract release: could not open the public key ring.")

Review Comment:
   The GPGService is only used in step7, so we may defer the initialization of the GpgService when that step is executed. 
   
   https://github.com/apache/fineract/blob/a90506c7e0841e16932af1c3c69c95166388ad96/buildSrc/src/main/groovy/org/apache/fineract/gradle/FineractPlugin.groovy#L335



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org