You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/02 21:54:59 UTC
[GitHub] [beam-wheels] amaliujia opened a new pull request #15: update
travis config based on https://config.travis-ci.com/explore
amaliujia opened a new pull request #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15
Travis-ci now has an online tool to validate travis config: https://config.travis-ci.com/explore.
I updated travis config based on the suggestions from the tool. E.g. fix warnings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] amaliujia edited a comment on issue #15: update
travis config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on issue #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#issuecomment-608111440
@aaltay @boyuanzz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] amaliujia commented on a change in pull request #15:
update travis config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#discussion_r402622210
##########
File path: .travis.yml
##########
@@ -16,7 +15,7 @@ env:
- BUILD_DEPENDS="Cython"
- TEST_DEPENDS=
-matrix:
+jobs:
exclude:
# Exclude the default Python 3.5 build
- python: 3.5
Review comment:
Actually this link might gives the real reason: https://docs.travis-ci.com/user/build-matrix/#explicitly-included-jobs-with-only-one-element-in-the-build-matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] aaltay commented on issue #15: update travis config
based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
aaltay commented on issue #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#issuecomment-608175122
> This change has fixed the "does not trigger build" problem.
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] amaliujia commented on a change in pull request #15:
update travis config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#discussion_r402620104
##########
File path: .travis.yml
##########
@@ -16,7 +15,7 @@ env:
- BUILD_DEPENDS="Cython"
- TEST_DEPENDS=
-matrix:
+jobs:
exclude:
# Exclude the default Python 3.5 build
- python: 3.5
Review comment:
The python version is 3.5 above but 3.5 is specified as "exclude" here. Is it the reason that making the build skipped?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] amaliujia commented on issue #15: update travis
config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#issuecomment-608120384
This change has fixed the "does not trigger build" problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] amaliujia commented on a change in pull request #15:
update travis config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#discussion_r402624271
##########
File path: .travis.yml
##########
@@ -96,9 +95,9 @@ deploy:
access_key_id: ${ACCESS_KEY_ID}
secret_access_key: ${SECRET_ACCESS_KEY}
bucket: "beam-wheels-staging"
- skip_cleanup: true
Review comment:
`skip_cleanup` is deprecated and it's replacement is `cleanup`
I should have provided a list of warning messages from https://config.travis-ci.com/explore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] aaltay commented on a change in pull request #15:
update travis config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#discussion_r402623417
##########
File path: .travis.yml
##########
@@ -16,7 +15,7 @@ env:
- BUILD_DEPENDS="Cython"
- TEST_DEPENDS=
-matrix:
+jobs:
exclude:
# Exclude the default Python 3.5 build
- python: 3.5
Review comment:
I am not sure what this does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] amaliujia merged pull request #15: update travis
config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
amaliujia merged pull request #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] aaltay commented on a change in pull request #15:
update travis config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#discussion_r402622997
##########
File path: .travis.yml
##########
@@ -96,9 +95,9 @@ deploy:
access_key_id: ${ACCESS_KEY_ID}
secret_access_key: ${SECRET_ACCESS_KEY}
bucket: "beam-wheels-staging"
- skip_cleanup: true
Review comment:
why was this true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam-wheels] amaliujia commented on issue #15: update travis
config based on https://config.travis-ci.com/explore
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #15: update travis config based on https://config.travis-ci.com/explore
URL: https://github.com/apache/beam-wheels/pull/15#issuecomment-608111440
@aaltay
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services