You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2016/05/30 19:06:03 UTC
[GitHub] incubator-quickstep pull request: DO NOT MERGE: CI w/ gRPC.
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/5
DO NOT MERGE: CI w/ gRPC.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep travis-grpc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit b69b6da2013d9d88a5929f41b24c86cc74e1c017
Author: Zuyu Zhang <zz...@pivotal.io>
Date: 2016-05-30T18:57:22Z
CI w/ gRPC.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: DO NOT MERGE: CI w/ gRPC To Test the Distribut...
Posted by navsan <gi...@git.apache.org>.
Github user navsan commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
It looks like clang can't find the standard libraries. Could you try -lstdc++ (or -lc++ if libc++ is installed)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: CI w/ gRPC To Test the Distributed Version.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@zuyu: Ok so we now reduce the configurations that we try. This seems bad in general. I understand Travis is timing out. Do we know why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: DO NOT MERGE: CI w/ gRPC To Test the Distribut...
Posted by navsan <gi...@git.apache.org>.
Github user navsan commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
I\u2019m not sure why the gflags-shared target already exists. Is it because gRPC has its own gflags? If so, how does the static target work?
@Zuyu, I don\u2019t think I\u2019ll be able to figure this out on my own.
> On Jun 14, 2016, at 19:51, Zuyu ZHANG <no...@github.com> wrote:
>
> @navsan <https://github.com/navsan> We need to fix the cmake error regarding gflags-shared (#13 <https://github.com/apache/incubator-quickstep/pull/13>) when ENABLE_DISTRIBUTED=ON:
>
> https://travis-ci.org/apache/incubator-quickstep/jobs/137651757#L3727 <https://travis-ci.org/apache/incubator-quickstep/jobs/137651757#L3727>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/apache/incubator-quickstep/pull/5#issuecomment-226059479>, or mute the thread <https://github.com/notifications/unsubscribe/ACZB633IxQRREEcoeQxa_ERDTWuTZDrYks5qL0ydgaJpZM4Ip_DT>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: DO NOT MERGE: CI w/ gRPC To Test the Distribut...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@navsan Do you have any insights regarding the clang linking issues? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: CI w/ gRPC To Test the Distributed Version.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
There is the only one gcc test killed by the Travis.
https://travis-ci.org/apache/incubator-quickstep/jobs/133990216#L5810
If we could somehow run it with 2 concurrent jobs like the rest tests, I think it would be fine. Otherwise, we may have to wait for that both the binary releases become available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: DO NOT MERGE: CI w/ gRPC To Test the Distribut...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@navsan I think it is related to how `tmb` explicitly specifies the library `gflags_nothreads-static`. And disabling the shared build works using `gcc`, although there are two cases that were killed due to time out.
FYI, linking w/ `libstdc++` does not fix the linking issues regarding `std::string` when using `clang`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: CI w/ gRPC To Test the Distributed Version.
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@zuyu Since we have have protobuf under third_party, should we just go and upgrade that and not have such a specific dependency?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: DO NOT MERGE: CI w/ gRPC To Test the Distribut...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@navsan We need to fix the `cmake` error regarding `gflags-shared` (#13) when `ENABLE_DISTRIBUTED=ON`:
https://travis-ci.org/apache/incubator-quickstep/jobs/137651757#L3727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #5: CI w/ gRPC To Test the Distributed Version.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
This is just a hack until the GRPC and Protobuf 3.0 becomes GA. And at that time, I bet that a binary version would be available as an `apt` package.
On the other hand, if we upgrade the protobuf third_party to 3.0 beta, we may encounter some linking issues when `grpc` tries to links `protobuf`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #5: DO NOT MERGE: CI w/ gRPC To Test the Di...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---