You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/06/02 16:43:49 UTC
[GitHub] flink pull request: [FLINK-2069] Fix Scala CSV Output Format
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/759
[FLINK-2069] Fix Scala CSV Output Format
Before, the Scala Streaming API used the Java CsvOutputFormat. This is not compatible with Scala Tuples. The FileSinkFunction would silently swallow the thrown exceptions and the job would finish cleanly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink fix-scala-csv-output
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #759
----
commit 16986ced8b6961bb2ada269b29dd4a5b59159983
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2015-06-02T14:37:06Z
[FLINK-2069] Fix Scala CSV Output Format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2069] Fix Scala CSV Output Format
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/759#issuecomment-108122772
Added a JIRA for the [issue](https://issues.apache.org/jira/browse/FLINK-2139).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2069] Fix Scala CSV Output Format
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/759#issuecomment-108083643
Are there any tests for the streaming output formats?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2069] Fix Scala CSV Output Format
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/759
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2069] Fix Scala CSV Output Format
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/759#issuecomment-108471089
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2069] Fix Scala CSV Output Format
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/759#issuecomment-108002285
Thanks for the fix, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2069] Fix Scala CSV Output Format
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/759#issuecomment-108093780
Not enough. `writeAsText` is covered a number of times in the integration tests and ITCases, but there is no test for other output formats.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---