[GitHub] [incubator-pinot] xiaohui-sun edited a comment on issue #5113: [TE] added a couple of validations to check if detection is subscribed & valid; cleaned up other validations

[GitBox <gi...@apache.org>]

xiaohui-sun edited a comment on issue #5113: [TE] added a couple of validations to check if detection is subscribed & valid; cleaned up other validations
URL: https://github.com/apache/incubator-pinot/pull/5113#issuecomment-595374306
 
 
   > > 1. Can expose multiple error messages together.
   > 
   > That might be better but I am sure how much value it will bring. We can club together some independent validations and show them together but we still won't be able to run validation on the complete config.
   
   We want to show all validation results to users. Currently any error will block the other validators.
   
   > 
   > > 1. Easier to add more validation rules.
   > 
   > The validations are already abstracted out and written in a separate validation class. What are you thinking about?
   
   It is pretty good now. Some improvement we can do: 
   1. Pass the error message more clearly. Some of the error message was wrapped in exceptions. Some of them are in precondition checks.
   2. The validators are coupled and states are shared. You can't run the validators separately. 
   3. Some validations are warnings and some are errors. We should differentiate them.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org