[jira] Commented: (SOLR-79) [PATCH] Using system properties in Solr configuration

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472403 ] 

Hoss Man commented on SOLR-79:
------------------------------

i haven't tested Erik's patch, but it reads clean to me.

a couple of minor nits...

1) it would be good to have some javadocs on substituteSystemProperties(Node)

2) if the system properties used were "solr.test.sys.prop1", etc. the patch wouldn't need to modify build.xml ... if we are going to set them explicitly in build.xml, there shold be a comment explaining which test uses them.

3) at first glance, i'm not sure if this would work, it would be nice to have a test for it...

    s = SolrConfig.config.get("propTest/[@attr='prop two']", "default");
    assertEquals("prefix-prop one-prop two-suffix", s);

4) it looks like it should work, but tests of Config.evaluate, Config.getNode, and the various DOMUtil methods would also be good

> [PATCH] Using system properties in Solr configuration
> -----------------------------------------------------
>
>                 Key: SOLR-79
>                 URL: https://issues.apache.org/jira/browse/SOLR-79
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Alexander Saar
>         Assigned To: Erik Hatcher
>            Priority: Minor
>         Attachments: solr-config-system-property.patch, solr-config-system-property.patch, solr-config-system-property.patch, solr-config-system-property.patch
>
>
> Actually it is not possible to use system properties for configuring the Solr engine. There should be a way of referencing system properties from solrconfig.xml, like {$prop.name}.
> The attached patch will provide this feature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.