You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tatu Saloranta (Jira)" <ji...@apache.org> on 2021/09/03 16:25:00 UTC
[jira] [Commented] (CASSANDRA-16855) Replace minor use of
`json-simple` with Jackson
[ https://issues.apache.org/jira/browse/CASSANDRA-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409595#comment-17409595 ]
Tatu Saloranta commented on CASSANDRA-16855:
--------------------------------------------
One possibility, too, would be for me to split changes into 2 (or if need be, more) PRs, starting with safest ones (adding missing test). This would make sense if someone with a better idea of hotspots/-paths could suggest split. More important change(s) should then be merged with a jmh test (or tests), or validated with load/stress-test for overall change (likely none measurable at high level).
> Replace minor use of `json-simple` with Jackson
> -----------------------------------------------
>
> Key: CASSANDRA-16855
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16855
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies, Local/Other, Tool/nodetool
> Reporter: Tatu Saloranta
> Assignee: Tatu Saloranta
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.x
>
>
> Jackson library is used for most JSON reading/writing, but there are couple of places where older "json-simple" library is used, mostly for diagnostics output. Replacing those minor usages would allow removal of a dependency, one for which the last release was made in 2012.
> Places where json-simple is used are:
> * src/java/org/apache/cassandra/db/ColumnFamilyStore.java
> * src/java/org/apache/cassandra/db/commitlog/CommitLogDescriptor.java
> * src/java/org/apache/cassandra/hints/HintsDescriptor.java
> * src/java/org/apache/cassandra/tools/nodetool/stats/StatsPrinter.java
> (and some matching usage in couple of test classes)
> I can take a stab at replacing these uses; it also looks like test coverage may be spotty for some (StatsPrinter json/yaml part has no tests for example).
> It is probably best to target this for "trunk" (4.1?).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org