You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/18 00:24:28 UTC
[GitHub] [incubator-tvm] apivovarov opened a new pull request #4738: Fix
padding in pooling op
apivovarov opened a new pull request #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738
Currently we have a bug in pooling op. The code calculated D, H and W padding but uses only D padding. H and W paddings are ignored.
This CR fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 commented on issue #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575860119
please add a test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] apivovarov edited a comment on issue #4738: Fix
padding in pooling op
Posted by GitBox <gi...@apache.org>.
apivovarov edited a comment on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575844275
@optima2005 @masahi @anijain2305 @alexgl-github @kevinthesun Can you have a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] apivovarov commented on issue #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
apivovarov commented on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575874464
How to test correctness of `oshape` calculation in `src/relay/op/nn/pooling.cc`? What test file is responsible for that? I tried to check output shape in [topi/tests/python/test_topi_pooling.py](https://github.com/apache/incubator-tvm/blob/master/topi/tests/python/test_topi_pooling.py#L288) but looks like it is not using formula defined in `pooling.cc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] apivovarov commented on issue #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
apivovarov commented on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-576976676
The test case was added. @vinx13, @anijain2305 can you have a look again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 commented on issue #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575936579
It's in `tests/python/relay/test_op_level2.py`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 commented on issue #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-576977731
Thanks @apivovarov @masahi this is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 edited a comment on issue #4738: Fix padding
in pooling op
Posted by GitBox <gi...@apache.org>.
vinx13 edited a comment on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575936579
It's in `tests/python/relay/test_op_level2.py`, you can check the result of infer_type in the test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575998139
you can just a test case where pooling has different pad size in each dimension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 merged pull request #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] apivovarov commented on issue #4738: Fix padding in
pooling op
Posted by GitBox <gi...@apache.org>.
apivovarov commented on issue #4738: Fix padding in pooling op
URL: https://github.com/apache/incubator-tvm/pull/4738#issuecomment-575844275
@anijain2305 @alexgl-github @kevinthesun Can you have a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services