You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by chunhui-shi <gi...@git.apache.org> on 2016/12/14 02:03:26 UTC
[GitHub] drill pull request #696: DRILL-4558: BSonReader should prepare buffer size a...
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/696
DRILL-4558: BSonReader should prepare buffer size as actual need
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chunhui-shi/drill DRILL-4558
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/696.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #696
----
commit fc0b7478efef1447ccca8965c8da001a04f243d4
Author: chunhui-shi <cs...@maprtech.com>
Date: 2016-12-14T02:00:49Z
DRILL-4558: BSonReader should prepare buffer size as actual need
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #696: DRILL-4558: BSonReader should prepare buffer size a...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/696#discussion_r96048977
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java ---
@@ -103,6 +103,17 @@ public void testStringType() throws IOException {
}
@Test
+ public void testSpecialCharStringType() throws IOException {
+ BsonDocument bsonDoc = new BsonDocument();
+ bsonDoc.append("stringKey", new BsonString("���������1"));
--- End diff --
Might want to put your value in a string, convert to byte but, and assert that the byte buf length differs in length from the string length. This will verify that this test is, in fact, testing the problem case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #696: DRILL-4558: BSonReader should prepare buffer size as actua...
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/696
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #696: DRILL-4558: BSonReader should prepare buffer size a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---