[rocketmq] branch develop updated: [ISSUE #6347] fix: use mutable list to avoid start fail when enable tiered store

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 3db8d039d [ISSUE #6347] fix: use mutable list to avoid start fail when enable tiered store
3db8d039d is described below

commit 3db8d039d18ba682f85985534df82250ab1b9fa8
Author: Lei Zhiyuan <le...@gmail.com>
AuthorDate: Thu Mar 16 11:01:34 2023 +0800

    [ISSUE #6347] fix: use mutable list to avoid start fail when enable tiered store
---
 .../org/apache/rocketmq/store/metrics/DefaultStoreMetricsManager.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/store/src/main/java/org/apache/rocketmq/store/metrics/DefaultStoreMetricsManager.java b/store/src/main/java/org/apache/rocketmq/store/metrics/DefaultStoreMetricsManager.java
index 9132761a6..ff87f6369 100644
--- a/store/src/main/java/org/apache/rocketmq/store/metrics/DefaultStoreMetricsManager.java
+++ b/store/src/main/java/org/apache/rocketmq/store/metrics/DefaultStoreMetricsManager.java
@@ -16,6 +16,7 @@
  */
 package org.apache.rocketmq.store.metrics;
 
+import com.google.common.collect.Lists;
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.common.AttributesBuilder;
 import io.opentelemetry.api.metrics.LongCounter;
@@ -24,7 +25,6 @@ import io.opentelemetry.api.metrics.ObservableLongGauge;
 import io.opentelemetry.sdk.metrics.InstrumentSelector;
 import io.opentelemetry.sdk.metrics.View;
 import java.io.File;
-import java.util.Collections;
 import java.util.List;
 import java.util.function.Supplier;
 import org.apache.rocketmq.common.Pair;
@@ -70,7 +70,7 @@ public class DefaultStoreMetricsManager {
     public static LongCounter timerEnqueueTotal = new NopLongCounter();
 
     public static List<Pair<InstrumentSelector, View>> getMetricsView() {
-        return Collections.emptyList();
+        return Lists.newArrayList();
     }
 
     public static void init(Meter meter, Supplier<AttributesBuilder> attributesBuilderSupplier,