You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/02 21:41:59 UTC

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3008: HBASE-25596: Fix NPE and avoid permanent unreplicated data due to EOF

sandeepvinayak commented on a change in pull request #3008:
URL: https://github.com/apache/hbase/pull/3008#discussion_r585930403



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java
##########
@@ -238,26 +243,27 @@ private static void startClusters() throws Exception {
     // as a component in deciding maximum number of parallel batches to send to the peer cluster.
     UTIL2.startMiniCluster(NUM_SLAVES2);
 
+    connection1 = ConnectionFactory.createConnection(CONF1);
+    connection2 = ConnectionFactory.createConnection(CONF2);
     admin = new ReplicationAdmin(CONF1);

Review comment:
       This was removed @apurtell. It was just one line change. 
   `admin = new ReplicationAdmin(CONF1);`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org