You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Indhumathi27 <gi...@git.apache.org> on 2018/11/05 10:50:09 UTC
[GitHub] carbondata pull request #2896: [WIP] Select Filter fails for Legacy store if...
GitHub user Indhumathi27 opened a pull request:
https://github.com/apache/carbondata/pull/2896
[WIP] Select Filter fails for Legacy store if DirectVecorFill is enabled
**Why this PR?**
When **isDirectVectorFill** is set to true, Select filter fails in Legacy Store throwing UnsupportedOperationException
**Solution:**
Set **isDirectVectorFill** to false for Legacy store
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Indhumathi27/carbondata scan_comp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2896
----
commit c2af1dc8ed8ea9ec5671d3fa107007c338ecbbef
Author: Indhumathi27 <in...@...>
Date: 2018-11-05T10:42:24Z
[CARBONDATA-3075] Select Filter fails for Legacy store if DirectVectorFill is enabled
----
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9541/
---
[GitHub] carbondata issue #2896: [WIP] Select Filter fails for Legacy store if Direct...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1272/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1506/
---
[GitHub] carbondata pull request #2896: [CARBONDATA-3075] Select Filter fails for Leg...
Posted by Indhumathi27 <gi...@git.apache.org>.
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2896#discussion_r230731270
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java ---
@@ -230,6 +230,11 @@ protected void initQuery(QueryModel queryModel) throws IOException {
updateColumns(queryModel, fileFooter.getColumnInTable(), blockInfo.getFilePath());
filePathToSegmentPropertiesMap.put(blockInfo.getFilePath(), segmentProperties);
}
+ //In case of Legacy store, set setDirectVectorFill to false,
+ // as filling vector directly is not supported for V2 store
--- End diff --
okay
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1505/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1292/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1496/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1293/
---
[GitHub] carbondata pull request #2896: [CARBONDATA-3075] Select Filter fails for Leg...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2896#discussion_r230728849
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java ---
@@ -230,6 +230,11 @@ protected void initQuery(QueryModel queryModel) throws IOException {
updateColumns(queryModel, fileFooter.getColumnInTable(), blockInfo.getFilePath());
filePathToSegmentPropertiesMap.put(blockInfo.getFilePath(), segmentProperties);
}
+ //In case of Legacy store, set setDirectVectorFill to false,
+ // as filling vector directly is not supported for V2 store
--- End diff --
not only v2... 'not supported for legacy store prior to v3'. Besides I do like you to add a warn log here and remove the comments.
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2896
LGTM
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by Indhumathi27 <gi...@git.apache.org>.
Github user Indhumathi27 commented on the issue:
https://github.com/apache/carbondata/pull/2896
Retest this please
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9554/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9553/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1280/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by Indhumathi27 <gi...@git.apache.org>.
Github user Indhumathi27 commented on the issue:
https://github.com/apache/carbondata/pull/2896
Retest this please
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9535/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by Indhumathi27 <gi...@git.apache.org>.
Github user Indhumathi27 commented on the issue:
https://github.com/apache/carbondata/pull/2896
Retest this please
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9547/
---
[GitHub] carbondata issue #2896: [WIP] Select Filter fails for Legacy store if Direct...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1486/
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1286/
---
[GitHub] carbondata pull request #2896: [CARBONDATA-3075] Select Filter fails for Leg...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2896
---
[GitHub] carbondata issue #2896: [CARBONDATA-3075] Select Filter fails for Legacy sto...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2896
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1501/
---