You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Harish Butani <rh...@gmail.com> on 2013/12/02 19:58:47 UTC
Review Request 15898: HIVE-5830: SubQuery: Not In subqueries should check if
subquery contains nulls in matching column
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15898/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: hive-5830
https://issues.apache.org/jira/browse/hive-5830
Repository: hive-git
Description
-------
As pointed out by Sivaramakrishnan Narayanan in HIVE-784 for not in when there are nulls in the SubQuery's matching column the Outer Query should return no rows.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java 753df79a
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e9d9ee7
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java ddc096d
ql/src/test/queries/clientpositive/subquery_notin.q d7eca3e
ql/src/test/results/clientpositive/subquery_multiinsert.q.out a917a13
ql/src/test/results/clientpositive/subquery_notin.q.out bf87e3b
ql/src/test/results/clientpositive/subquery_notin_having.q.out f9598c2
Diff: https://reviews.apache.org/r/15898/diff/
Testing
-------
ran all subquery tests.
added new test for notin with null values.
Thanks,
Harish Butani
Re: Review Request 15898: HIVE-5830: SubQuery: Not In subqueries should
check if subquery contains nulls in matching column
Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15898/
-----------------------------------------------------------
(Updated Dec. 9, 2013, 1:52 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
added comments in SubQueryUtils methods.
Bugs: hive-5830
https://issues.apache.org/jira/browse/hive-5830
Repository: hive-git
Description
-------
As pointed out by Sivaramakrishnan Narayanan in HIVE-784 for not in when there are nulls in the SubQuery's matching column the Outer Query should return no rows.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java 753df79a
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 08b9e58
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java ddc096d
ql/src/test/queries/clientpositive/subquery_notin.q d7eca3e
ql/src/test/results/clientpositive/subquery_multiinsert.q.out a917a13
ql/src/test/results/clientpositive/subquery_notin.q.out bf87e3b
ql/src/test/results/clientpositive/subquery_notin_having.q.out f9598c2
Diff: https://reviews.apache.org/r/15898/diff/
Testing
-------
ran all subquery tests.
added new test for notin with null values.
Thanks,
Harish Butani
Re: Review Request 15898: HIVE-5830: SubQuery: Not In subqueries should
check if subquery contains nulls in matching column
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15898/#review29932
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java
<https://reviews.apache.org/r/15898/#comment57405>
It will be good to add a comment for all these static methods to tell what kind of query form each of these methods are generating like:
select ... from T1 LOJ T2 ..
and so on..
- Ashutosh Chauhan
On Dec. 2, 2013, 6:58 p.m., Harish Butani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15898/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2013, 6:58 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: hive-5830
> https://issues.apache.org/jira/browse/hive-5830
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> As pointed out by Sivaramakrishnan Narayanan in HIVE-784 for not in when there are nulls in the SubQuery's matching column the Outer Query should return no rows.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java 753df79a
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e9d9ee7
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java ddc096d
> ql/src/test/queries/clientpositive/subquery_notin.q d7eca3e
> ql/src/test/results/clientpositive/subquery_multiinsert.q.out a917a13
> ql/src/test/results/clientpositive/subquery_notin.q.out bf87e3b
> ql/src/test/results/clientpositive/subquery_notin_having.q.out f9598c2
>
> Diff: https://reviews.apache.org/r/15898/diff/
>
>
> Testing
> -------
>
> ran all subquery tests.
> added new test for notin with null values.
>
>
> Thanks,
>
> Harish Butani
>
>