You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (JIRA)" <ji...@apache.org> on 2016/11/18 17:10:58 UTC
[jira] [Commented] (SLING-6304) Get rid of
EmbeddedArchetypeInstaller
[ https://issues.apache.org/jira/browse/SLING-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677162#comment-15677162 ]
Konrad Windszus commented on SLING-6304:
----------------------------------------
Attached is a patch which removes that file.
[~rombert] Could you have a look?
> Get rid of EmbeddedArchetypeInstaller
> -------------------------------------
>
> Key: SLING-6304
> URL: https://issues.apache.org/jira/browse/SLING-6304
> Project: Sling
> Issue Type: Improvement
> Components: IDE
> Affects Versions: Sling Eclipse IDE 1.0.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6304-v1.patch
>
>
> With SLING-3592 no longer any embedded archetypes are being used. But the class {{EmbeddedArchetypeInstaller}} does still exist, although it is only used from the test {{EmbeddedArchetypeInstallerTest}}.
> If in the future we ever want to rely on embedded archetypes, we rather rely on the extension point of m2e 1.7 (http://www.eclipse.org/m2e/documentation/release-notes-17.html#support-for-plugin-embedded-archetype-catalogs, https://bugs.eclipse.org/bugs/show_bug.cgi?id=490230).
> I therefore propose to remove the according class (because it also relies on m2e internal classes).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)