You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/06/08 11:55:46 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4386: Consolidate ByteArray::from_iterator
tustvold opened a new pull request, #4386:
URL: https://github.com/apache/arrow-rs/pull/4386
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Reduces code duplication, and is marginally faster for smaller arrays (likely because of StringBuilder has a minimum allocation of 1024 bytes).
```
array_string_from_vec 128
time: [945.97 ns 946.65 ns 947.40 ns]
change: [-19.195% -19.061% -18.890%] (p = 0.00 < 0.05)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
4 (4.00%) low mild
6 (6.00%) high mild
4 (4.00%) high severe
array_string_from_vec 256
time: [1.6194 µs 1.6204 µs 1.6215 µs]
change: [-4.5788% -4.4338% -4.2716%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe
array_string_from_vec 512
time: [2.7773 µs 2.7785 µs 2.7799 µs]
change: [-0.1694% -0.0183% +0.1938%] (p = 0.87 > 0.05)
No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
7 (7.00%) high mild
2 (2.00%) high severe
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4386: Consolidate ByteArray::from_iterator
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4386:
URL: https://github.com/apache/arrow-rs/pull/4386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org