[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 )

Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners
......................................................................


Patch Set 5:

(1 comment)

I'm still seeing some crashes if I run this in a loop locally:

  I=0; while impala-py.test tests/query_test/test_scanners_fuzz.py -k "rc or seq" -n 4 --verbose; do echo ITER $I; I=$((I + 1)); done

It seem to be causing a crash about every 10 iterations.

http://gerrit.cloudera.org:8080/#/c/8936/5/be/src/exec/hdfs-rcfile-scanner.cc
File be/src/exec/hdfs-rcfile-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/8936/5/be/src/exec/hdfs-rcfile-scanner.cc@119
PS5, Line 119:     ss << __FILE__ << ":" << __LINE__<< " Invalid RCFILE_VERSION_HEADER: '"
> I was wondering how do we differentiate two similar messages coming from di
It seems like the message text should be enough to distinguish, right?



-- 
To view, visit http://gerrit.cloudera.org:8080/8936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9cfc38af3f30c65ada9734eb471dbfa6ecdd74a
Gerrit-Change-Number: 8936
Gerrit-PatchSet: 5
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 00:12:15 +0000
Gerrit-HasComments: Yes