You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/14 15:45:06 UTC

[GitHub] [geode-native] mreddington commented on pull request #874: GEODE-9639: Removed the use of std::unary_function.

mreddington commented on pull request #874:
URL: https://github.com/apache/geode-native/pull/874#issuecomment-943483292


   Aren't all the requested changes outside the scope of this PR? I was to make the library's client interface compatible with C++20. This PR as it stands accomplishes that. If you want me to go in and remove other cruft, make other changes to the internal implementation, fine - just make a new JIRA ticket for it. As it stands, these things you're asking to change don't affect ABI compatibility with C++20 along the same toolchain, and that has already been proven. What does affect ABI compatibility is changing toolchains from VS 2017 to VS 2019, which internal changes won't fix, either.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org