You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/10 15:09:00 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

bartekkuncer opened a new pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004


   ## Description ##
   This change removes USE_MKL_IF_AVAILABLE flag and its dependencies as it is deprecated.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#discussion_r592227448



##########
File path: cmake/ChooseBlas.cmake
##########
@@ -23,14 +23,6 @@ set(INTEL_OPT_ROOT "/opt/intel" CACHE PATH "Folder contains root-installed intel
 
 if(DEFINED USE_BLAS)
   set(BLAS "${USE_BLAS}")
-else()
-  if (USE_MKL_IF_AVAILABLE)
-    # Setting up BLAS_mkl_MKLROOT for non-Ubuntu 20.04 OSes
-    find_path(BLAS_mkl_MKLROOT mkl PATHS $ENV{MKLROOT} ${INTEL_HOME_ROOT} ${INTEL_OPT_ROOT})
-    if(NOT BLAS_mkl_MKLROOT STREQUAL "BLAS_mkl_MKLROOT-NOTFOUND")
-      set(BLAS "MKL")
-    endif()
-  endif()

Review comment:
       Well now if the user wants to use mkl he has to explicitly declare USE_BLAS=mkl. Otherwise with no BLAS set, OpenBLAS will be used. Do we want to keep this functionality now as default in mxnet?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-797015862


   @mxnet-bot run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#discussion_r592405463



##########
File path: ci/docker/runtime_functions.sh
##########
@@ -318,7 +306,6 @@ build_ubuntu_cpu_openblas() {
         -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
         -DENABLE_TESTCOVERAGE=ON \
         -DUSE_TVM_OP=ON \

Review comment:
       USE_BLAS is needed to keep openblas here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-797015908


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-797402630


   @mxnet-bot run ci [centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-797494764


   @mxnet-bot run ci [centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-797402683


   Jenkins CI successfully triggered : [centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-797579007


   @szha Please merge. This change removes unnecessary build flag USE_MKL_IF_AVAILABLE to simplify the compilation process.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] akarbown commented on a change in pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
akarbown commented on a change in pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#discussion_r592221577



##########
File path: cmake/ChooseBlas.cmake
##########
@@ -23,14 +23,6 @@ set(INTEL_OPT_ROOT "/opt/intel" CACHE PATH "Folder contains root-installed intel
 
 if(DEFINED USE_BLAS)
   set(BLAS "${USE_BLAS}")
-else()
-  if (USE_MKL_IF_AVAILABLE)
-    # Setting up BLAS_mkl_MKLROOT for non-Ubuntu 20.04 OSes
-    find_path(BLAS_mkl_MKLROOT mkl PATHS $ENV{MKLROOT} ${INTEL_HOME_ROOT} ${INTEL_OPT_ROOT})
-    if(NOT BLAS_mkl_MKLROOT STREQUAL "BLAS_mkl_MKLROOT-NOTFOUND")
-      set(BLAS "MKL")
-    endif()
-  endif()

Review comment:
       If the user doesn't specify any BLAS and USE_MKL_IF_AVAILABLE=ON the 1st priority is MKL, if not available try OpenBLAS and the other that is available. Can you verify that after removing those lines it is still has the same order priority?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#discussion_r592395340



##########
File path: cmake/ChooseBlas.cmake
##########
@@ -23,14 +23,6 @@ set(INTEL_OPT_ROOT "/opt/intel" CACHE PATH "Folder contains root-installed intel
 
 if(DEFINED USE_BLAS)
   set(BLAS "${USE_BLAS}")
-else()
-  if (USE_MKL_IF_AVAILABLE)
-    # Setting up BLAS_mkl_MKLROOT for non-Ubuntu 20.04 OSes
-    find_path(BLAS_mkl_MKLROOT mkl PATHS $ENV{MKLROOT} ${INTEL_HOME_ROOT} ${INTEL_OPT_ROOT})
-    if(NOT BLAS_mkl_MKLROOT STREQUAL "BLAS_mkl_MKLROOT-NOTFOUND")
-      set(BLAS "MKL")
-    endif()
-  endif()

Review comment:
       Already done :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-795573214


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, unix-gpu, sanity, website, centos-cpu, windows-gpu, miscellaneous, unix-cpu, edge, clang, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#issuecomment-797494829


   Jenkins CI successfully triggered : [centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu merged pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org