[GitHub] [accumulo-testing] DomGarguilo commented on a change in pull request #176: Some minor code cleanup throughout accumulo-testing

[GitBox <gi...@apache.org>]

DomGarguilo commented on a change in pull request #176:
URL: https://github.com/apache/accumulo-testing/pull/176#discussion_r764046703



##########
File path: src/main/java/org/apache/accumulo/testing/randomwalk/shard/Grep.java
##########
@@ -88,13 +88,11 @@ public void visit(State state, RandWalkEnv env, Properties props) throws Excepti
     bs.close();
 
     if (!documentsFoundInIndex.equals(documentsFoundByGrep)) {
-      throw new Exception(
-          "Set of documents found not equal for words " + Arrays.asList(words).toString() + " "
-              + documentsFoundInIndex + " " + documentsFoundByGrep);
+      throw new Exception("Set of documents found not equal for words " + Arrays.asList(words) + " "

Review comment:
       ```suggestion
         throw new Exception("Set of documents found not equal for words " + Arrays.toString(words) + " "
   ```
   Does the same thing without having to first convert it to List.

##########
File path: src/main/java/org/apache/accumulo/testing/randomwalk/shard/Grep.java
##########
@@ -88,13 +88,11 @@ public void visit(State state, RandWalkEnv env, Properties props) throws Excepti
     bs.close();
 
     if (!documentsFoundInIndex.equals(documentsFoundByGrep)) {
-      throw new Exception(
-          "Set of documents found not equal for words " + Arrays.asList(words).toString() + " "
-              + documentsFoundInIndex + " " + documentsFoundByGrep);
+      throw new Exception("Set of documents found not equal for words " + Arrays.asList(words) + " "
+          + documentsFoundInIndex + " " + documentsFoundByGrep);
     }
 
-    log.debug("Grep and index agree " + Arrays.asList(words).toString() + " "
-        + documentsFoundInIndex.size());
+    log.debug("Grep and index agree " + Arrays.asList(words) + " " + documentsFoundInIndex.size());

Review comment:
       ```suggestion
       log.debug("Grep and index agree " + Arrays.toString(words) + " " + documentsFoundInIndex.size());
   ```
   Does the same thing without having to first convert it to List.

##########
File path: src/main/java/org/apache/accumulo/testing/randomwalk/concurrent/CreateTable.java
##########
@@ -45,7 +45,7 @@ public void visit(State state, RandWalkEnv env, Properties props) throws Excepti
       else
         throw e;
     } catch (IllegalArgumentException e) {
-      log.debug("Create: " + e.toString());
+      log.debug("Create: " + e);

Review comment:
       ```suggestion
         log.debug("Create: {}", e);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org