You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/12/22 05:36:54 UTC

Review Request 54962: Search API fix

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54962/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.


Repository: atlas


Description
-------

Search API fix

1. Java API to return empty container object
2. REST API to return 204 No Content (after doing some online research e.g. StackOverflow/blogs etc, might not be absolute source of truth)


Diffs
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 94a249c4 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java a7124bf8 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 95a34b01 
  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 9acfb2fe 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 27c2c742 

Diff: https://reviews.apache.org/r/54962/diff/


Testing
-------

mvn clean install -Pdist executing successfully.


Thanks,

Apoorv Naik

Re: Review Request 54962: Search API fix

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54962/#review160092
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java (line 272)
<https://reviews.apache.org/r/54962/#comment231084>

    REST API methods like this one should throw WebApplicationException. Please review and update.



webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java (line 422)
<https://reviews.apache.org/r/54962/#comment231085>

    Please review other search*() methods and update them to handle empty results similarly.


- Madhan Neethiraj


On Dec. 22, 2016, 5:36 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54962/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 5:36 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Search API fix
> 
> 1. Java API to return empty container object
> 2. REST API to return 204 No Content (after doing some online research e.g. StackOverflow/blogs etc, might not be absolute source of truth)
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 94a249c4 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java a7124bf8 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 95a34b01 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 9acfb2fe 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 27c2c742 
> 
> Diff: https://reviews.apache.org/r/54962/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -Pdist executing successfully.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54962: Search API fix

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54962/
-----------------------------------------------------------

(Updated Dec. 23, 2016, 7:59 p.m.)


Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.


Changes
-------

Addressed review comments.


Repository: atlas


Description
-------

Search API fix

1. Java API to return empty container object
2. REST API to return 204 No Content (after doing some online research e.g. StackOverflow/blogs etc, might not be absolute source of truth)


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 94a249c 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 7d6e593 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 95a34b0 
  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 9acfb2f 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 27c2c74 

Diff: https://reviews.apache.org/r/54962/diff/


Testing
-------

mvn clean install -Pdist executing successfully.


Thanks,

Apoorv Naik