You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/07/20 17:40:38 UTC
Review Request 61003: GEODE-393: GetRegionFunction uses the cache in
the FunctionContext
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/
-----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-393: GetRegionFunction uses the cache in the FunctionContext
Diffs
-----
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java d52492466d521fb25f410e7c03b3d9808aabe67c
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/61003/diff/1/
Testing
-------
added test and precheckin funning
Thanks,
Jinmei Liao
Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache
in the FunctionContext
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/#review181066
-----------------------------------------------------------
Ship it!
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java
Lines 17 (patched)
<https://reviews.apache.org/r/61003/#comment256497>
Blank line is not needed between license and package.
- Ken Howe
On July 20, 2017, 5:40 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61003/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 5:40 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-393: GetRegionFunction uses the cache in the FunctionContext
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java d52492466d521fb25f410e7c03b3d9808aabe67c
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61003/diff/1/
>
>
> Testing
> -------
>
> added test and precheckin funning
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache
in the FunctionContext
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/#review181275
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On July 20, 2017, 5:40 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61003/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 5:40 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-393: GetRegionFunction uses the cache in the FunctionContext
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java d52492466d521fb25f410e7c03b3d9808aabe67c
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61003/diff/1/
>
>
> Testing
> -------
>
> added test and precheckin funning
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache
in the FunctionContext
Posted by Emily Yeh <ey...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/#review181266
-----------------------------------------------------------
Ship it!
Ship It!
- Emily Yeh
On July 20, 2017, 5:40 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61003/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 5:40 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-393: GetRegionFunction uses the cache in the FunctionContext
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java d52492466d521fb25f410e7c03b3d9808aabe67c
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61003/diff/1/
>
>
> Testing
> -------
>
> added test and precheckin funning
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache
in the FunctionContext
Posted by Patrick Rhomberg <pr...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61003/#review181272
-----------------------------------------------------------
Ship it!
Ship It!
- Patrick Rhomberg
On July 20, 2017, 5:40 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61003/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 5:40 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-393: GetRegionFunction uses the cache in the FunctionContext
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java d52492466d521fb25f410e7c03b3d9808aabe67c
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61003/diff/1/
>
>
> Testing
> -------
>
> added test and precheckin funning
>
>
> Thanks,
>
> Jinmei Liao
>
>