[GitHub] [lucene] uschindler commented on a diff in pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

["uschindler (via GitHub)" <gi...@apache.org>]

uschindler commented on code in PR #12376:
URL: https://github.com/apache/lucene/pull/12376#discussion_r1231278902


##########
lucene/core/src/java20/org/apache/lucene/util/VectorUtilPanamaProvider.java:
##########
@@ -295,7 +301,7 @@ public int dotProduct(byte[] a, byte[] b) {
     int res = 0;
     // only vectorize if we'll at least enter the loop a single time, and we have at least 128-bit
     // vectors (256-bit on intel to dodge performance landmines)
-    if (a.length >= 16 && IS_AMD64_WITHOUT_AVX2 == false) {
+    if (a.length >= 16 && hasFastIntegerVectors) {

Review Comment:
   Thats ok, because in production we only have exactly one instance of this class, so it does not matter, it is optimized away.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org