You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2019/08/10 06:07:13 UTC

[GitHub] [incubator-datasketches-java] michaelschiff removed a comment on issue #265: PairwiseSetOperations.aNotB throws ArrayOutOfBoundsException

michaelschiff removed a comment on issue #265: PairwiseSetOperations.aNotB throws ArrayOutOfBoundsException
URL: https://github.com/apache/incubator-datasketches-java/issues/265#issuecomment-520121606
 
 
   The problem is this line of PairwiseSetOperations
   
   ```
       return HeapCompactOrderedSketch
           .compact(Arrays.copyOf(outCache, outCount), emptyRule, seedHash, outCount, thetaLong);
   ```
   
   In the case of the intersection above `outCache` is the size of the min of the two inner caches (non-zero) and filled with 0's (since the two sets dont overlap).  `outCount` is 0.  `Arrays.copyOf(outCache, outCount)` then will produce a 0 len array.  The `empty` param is set based on whether _either of the input sketches was empty_ instead of whether the result of the intersection is empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org