You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/20 06:15:01 UTC

[GitHub] [incubator-superset] nytai opened a new pull request #9591: [Build] moves prettier check to separate script

nytai opened a new pull request #9591:
URL: https://github.com/apache/incubator-superset/pull/9591


   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [x] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   I added the prettier check script a while back to check formatting in css files. It doesn't need to be part of the regular lint check as there's some redundancy with eslint. However it does need to run on CI to ensure no unformatted css files slip through (eslint isn't checking style files). 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on issue #9591: [Build] moves prettier check to separate script

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9591:
URL: https://github.com/apache/incubator-superset/pull/9591#issuecomment-616731943


   I think you could use https://github.com/pre-commit/mirrors-eslint?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #9591: [Build] moves prettier check to separate script

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9591:
URL: https://github.com/apache/incubator-superset/pull/9591#issuecomment-616684129


   @etr2460 we have a pre-commit hook?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on issue #9591: [Build] moves prettier check to separate script

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #9591:
URL: https://github.com/apache/incubator-superset/pull/9591#issuecomment-616845628


   Can we please not have pre-commit hooks? It slows things down and not really pleasant to use. Most IDEs, if properly configured, would already warn these errors. 
   
   Redash guys actually removed it from their repo: https://github.com/getredash/redash/pull/4435


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on issue #9591: [Build] moves prettier check to separate script

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #9591:
URL: https://github.com/apache/incubator-superset/pull/9591#issuecomment-616845628


   Can we please not have pre-commit hooks? It slows things down and not really pleasant to use. Most IDEs, if properly configured, would already warn these errors. 
   
   Redash guys actually removed it from their repo not so long ago: https://github.com/getredash/redash/pull/4435


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on issue #9591: [Build] moves prettier check to separate script

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9591:
URL: https://github.com/apache/incubator-superset/pull/9591#issuecomment-616845628


   Can we not have pre-commit hooks? It slows things down and not really pleasant to use. Most IDEs, if properly configured, would already warn these errors. 
   
   Redash guys actually removed it from their repo: https://github.com/getredash/redash/pull/4435


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #9591: [Build] moves prettier check to separate script

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9591:
URL: https://github.com/apache/incubator-superset/pull/9591#issuecomment-616686510


   the only thing I found is https://github.com/apache/incubator-superset/blob/master/.pre-commit-config.yaml and that looks like it only includes python checks. Is there another one concerned with npm checks? Or should we consider adding npm checks here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on issue #9591: [Build] moves prettier check to separate script

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9591:
URL: https://github.com/apache/incubator-superset/pull/9591#issuecomment-616826623


   But to be clear, my comment isn't blocking this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org