You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/10/25 02:08:59 UTC
[jira] Created: (ZOOKEEPER-558) server "sent" stats not being
updated
server "sent" stats not being updated
-------------------------------------
Key: ZOOKEEPER-558
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
Project: Zookeeper
Issue Type: Bug
Components: server
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Priority: Critical
Fix For: 3.3.0
the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774510#action_12774510 ]
Patrick Hunt commented on ZOOKEEPER-558:
----------------------------------------
The idea with catching Exception (current code before/after patch) is to warn if
something unexpected happens (esp so that we'll know about
it and have a chance to fix). Except in the case where we are closing the
connection. All kinds of weird errors could be thrown (not just by write afaict)
and we don't want to bother the user with that, at least not at warn level during close.
I don't think there's one or two of these potential sites, afaict that's why the code
had this originally (a big net).
That's the theory at least behind the refactorings in the patch...
I'd like this to go through unless you have something concrete in mind - I'd be happy
to explore further as additional JIRAs for example. (if you feel strongly to wait
then we could do that too)
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771468#action_12771468 ]
Patrick Hunt commented on ZOOKEEPER-558:
----------------------------------------
looks like this may be more serious, afaict some sendbuffer(closeconn) will (may) be ignored. not sure this was thought out when the short-circuit optimization was made. esp around four letter words.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774554#action_12774554 ]
Patrick Hunt commented on ZOOKEEPER-558:
----------------------------------------
I'm probably snow blind from looking at it too long.
Henry, easiest way for you to explain it is to create a jira and attach a patch. ;-) This is just
a small step, still lots of opportunity for improving the user experience in particular.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-558:
------------------------------------
Hadoop Flags: [Reviewed]
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773268#action_12773268 ]
Mahadev konar commented on ZOOKEEPER-558:
-----------------------------------------
was looking at the patch.
any reason to add
{code}
private static final long serialVersionUID
{code}
in the new exceptions? The exceptions are IOException and serializing and deserializing them as IOException serialversion should be fine. no?
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772814#action_12772814 ]
Hadoop QA commented on ZOOKEEPER-558:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423863/ZOOKEEPER-558.patch
against trunk revision 831486.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/45/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/45/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/45/console
This message is automatically generated.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-558:
-----------------------------------
Status: Open (was: Patch Available)
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-558:
-----------------------------------
Status: Patch Available (was: Open)
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-558:
-----------------------------------
Attachment: ZOOKEEPER-558.patch
This patch addresses the sent count issue (counter update was missing), additionally I addressed a number
of session establishment/teardown issues that I found while fixing this:
1) better logging of session est/teardown, much of this was based on user feedback such as ZOOKEEPER-565 ZOOKEEPER-564
Much of this was cleaning up the log text and using common terminology for the messages themselves
1.1) some of 1) required better error handling. A lot of the changed code was throwing general IOExceptions, rather than throwing
more specific exceptions allowing higher layer code to properly report the issue.
2) while closing a client connection the connection close response was not always sent to the client
3) in some cases the server would not close the connection (closeconn buffer was not being queued) properly. this would happen anyway when the client closed the connection, but the server should do the right thing regardless
4) calling close more than once just returns after the first call
5) added testableWaitForShutdown to ZooKeeper to allow tests to validate that the client has shutdown all threads
(this is test only)
6) reading a client sockets now reads the entire request in one shot if possible. previously we would re-poll the
selector after reading the length header.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-558:
-----------------------------------
Attachment: ZOOKEEPER-558.patch
Same as last patch except cleared up the findbugs issue.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-558:
-----------------------------------
Status: Patch Available (was: Open)
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774522#action_12774522 ]
Henry Robinson commented on ZOOKEEPER-558:
------------------------------------------
No problem - like I say those were tiny issues and shouldn't have stopped the patch being committed.
I understand about catching Exception; I was just wondering why we couldn't do
catch (IOException e) { ... }
catch (SessionExpireException e) { ... }
catch (Exception e) { ... }
rather than the explicit instanceof checks? I feel like I'm probably missing something subtle here, and it's moot anyhow since the patch went in :)
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-558:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed revision 833620.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774727#action_12774727 ]
Hudson commented on ZOOKEEPER-558:
----------------------------------
Integrated in ZooKeeper-trunk #522 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/])
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774519#action_12774519 ]
Benjamin Reed commented on ZOOKEEPER-558:
-----------------------------------------
i agree, breaking down the reasons behind the IOException is great! sorry i didn't see your comment before committing henry. i couldn't think of a nicer way to do the if conditions, but it would be cool to come up with one.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-558:
--------------------------------------
Assignee: Patrick Hunt
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773102#action_12773102 ]
Hadoop QA commented on ZOOKEEPER-558:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423930/ZOOKEEPER-558.patch
against trunk revision 831486.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/46/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/46/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/46/console
This message is automatically generated.
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774473#action_12774473 ]
Henry Robinson commented on ZOOKEEPER-558:
------------------------------------------
Big +1 on this patch from me; a bunch of very necessary refactorings as well the bug fix. Couple of tiny nits
{{+ // this is ugly, you have a better way speak up
+ if (e instanceof SessionExpiredException) {
+ LOG.info(e.getMessage() + ", closing socket connection");
+ } else if (e instanceof SessionTimeoutException) {
+ LOG.info(e.getMessage() + RETRY_CONN_MSG);
+ } else if (e instanceof EndOfStreamException) {
+ LOG.info(e.getMessage() + RETRY_CONN_MSG);
+ } else {
+ LOG.warn("Session 0x"
+ + Long.toHexString(getSessionId())
+ + " for server "
+ + ((SocketChannel)sockKey.channel())
+ .socket().getRemoteSocketAddress()
+ + ", unexpected error"
+ + RETRY_CONN_MSG,
+ e);
+ }
}}
Is the better way to have catch clauses for each exception type?.
{{+ try {
+ sock.write(bb);
+ } catch (IOException e) {
+ // we are just doing best effort right now
+ }}}
Debug message here?
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server "sent" stats not being
updated
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773277#action_12773277 ]
Patrick Hunt commented on ZOOKEEPER-558:
----------------------------------------
eclipse warns otw if you don't have the uid. no other reason
> server "sent" stats not being updated
> -------------------------------------
>
> Key: ZOOKEEPER-558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch
>
>
> the server and connection "sent" stat is not being updated. if you run "stat" on the client port the sent packets is much lower than it should be
> seems that sendbuffer is not updating the stats when it shortcircuits the send.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.