You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2016/06/03 10:09:40 UTC
Review Request 48201: LENS-1157: Execute with timeout fails to read
metadata when user requests streamed results
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48201/
-----------------------------------------------------------
Review request for lens.
Bugs: lens-1157
https://issues.apache.org/jira/browse/lens-1157
Repository: lens
Description
-------
- Caching resultset metadata in PartiallyFetchedInMemoryResultSet
- updated wait logic in executeTimeoutInternal
- Added extra logs in some places that were synchronized on query context
- Added test cases for JDBC queries in Lens-Server
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 959a5b243b2f956d073edbc8c0fee335b17a0a6e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PartiallyFetchedInMemoryResultSet.java 59918bd70c13dafb4b0e852cb0f3154d03abed3f
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 379d5323cd2f0a131c49259e1ca47ade0b0d97bd
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
lens-server/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 9ed0c871b55270555f6d38e9f8ab4dce3c1aa14c
Diff: https://reviews.apache.org/r/48201/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.658s]
[INFO] Lens .............................................. SUCCESS [2.565s]
[INFO] Lens API .......................................... SUCCESS [19.810s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.707s]
[INFO] Lens Cube ......................................... SUCCESS [17:16.708s]
[INFO] Lens DB storage ................................... SUCCESS [16.408s]
[INFO] Lens Query Library ................................ SUCCESS [12.782s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:24.955s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.652s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.758s]
[INFO] Lens Server ....................................... SUCCESS [9:05.887s]
[INFO] Lens client ....................................... SUCCESS [1:30.074s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.700s]
[INFO] Lens Examples ..................................... SUCCESS [8.281s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.661s]
[INFO] Lens Distribution ................................. SUCCESS [9.474s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:14.503s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.662s]
[INFO] Lens Regression ................................... SUCCESS [12.419s]
[INFO] Lens UI ........................................... SUCCESS [27.062s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:59.406s
[INFO] Finished at: Fri Jun 03 09:38:10 UTC 2016
[INFO] Final Memory: 187M/2357M
Thanks,
Puneet Gupta
Re: Review Request 48201: LENS-1157: Execute with timeout fails to
read metadata when user requests streamed results
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48201/#review136054
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 3, 2016, 10:09 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48201/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 10:09 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-1157
> https://issues.apache.org/jira/browse/lens-1157
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Caching resultset metadata in PartiallyFetchedInMemoryResultSet
> - updated wait logic in executeTimeoutInternal
> - Added extra logs in some places that were synchronized on query context
> - Added test cases for JDBC queries in Lens-Server
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 959a5b243b2f956d073edbc8c0fee335b17a0a6e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PartiallyFetchedInMemoryResultSet.java 59918bd70c13dafb4b0e852cb0f3154d03abed3f
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 379d5323cd2f0a131c49259e1ca47ade0b0d97bd
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b6ec42268f9d71897e54beaaead3c2101b5dc06e
> lens-server/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 9ed0c871b55270555f6d38e9f8ab4dce3c1aa14c
>
> Diff: https://reviews.apache.org/r/48201/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.658s]
> [INFO] Lens .............................................. SUCCESS [2.565s]
> [INFO] Lens API .......................................... SUCCESS [19.810s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.707s]
> [INFO] Lens Cube ......................................... SUCCESS [17:16.708s]
> [INFO] Lens DB storage ................................... SUCCESS [16.408s]
> [INFO] Lens Query Library ................................ SUCCESS [12.782s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:24.955s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.652s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.758s]
> [INFO] Lens Server ....................................... SUCCESS [9:05.887s]
> [INFO] Lens client ....................................... SUCCESS [1:30.074s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.700s]
> [INFO] Lens Examples ..................................... SUCCESS [8.281s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.661s]
> [INFO] Lens Distribution ................................. SUCCESS [9.474s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:14.503s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.662s]
> [INFO] Lens Regression ................................... SUCCESS [12.419s]
> [INFO] Lens UI ........................................... SUCCESS [27.062s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:59.406s
> [INFO] Finished at: Fri Jun 03 09:38:10 UTC 2016
> [INFO] Final Memory: 187M/2357M
>
>
> Thanks,
>
> Puneet Gupta
>
>