You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2014/09/10 02:17:16 UTC

[GitHub] incubator-streams pull request: Streams 167

GitHub user steveblackmon opened a pull request:

    https://github.com/apache/incubator-streams/pull/81

    Streams 167

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-streams STREAMS-167

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #81
    
----
commit 411f0fa905bba84adcdba5568a295132e1b6d0b7
Author: sblackmon <sb...@apache.org>
Date:   2014-09-09T21:40:19Z

    resolves STREAMS-167

commit 35a8fbf4b33fa6f996ed9dd0927ff46aedd85c8f
Author: sblackmon <sb...@apache.org>
Date:   2014-09-10T00:15:12Z

    resolves STREAMS-167
    naming consistency

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: Streams 167

Posted by renato2099 <gi...@git.apache.org>.

Github user renato2099 commented on the pull request:

    https://github.com/apache/incubator-streams/pull/81#issuecomment-55087970
  
    LGTM
    But @steveblackmon  could you explain the reasoning behind the renaming of TwitterStreamConfigurator to TwitterConfigurator? Is it just to make it shorter? or to make it compatible with the rest of providers?
    Thanks! If somebody could merge this would be great :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: Streams 167

Posted by steveblackmon <gi...@git.apache.org>.

Github user steveblackmon commented on the pull request:

    https://github.com/apache/incubator-streams/pull/81#issuecomment-55193305
  
    @renato2099 The scope of the module expanded, but the Configurator had a too-specific name.  Now it's in line with the pattern elsewhere, one Configurator per module capable of returning each type of Configuration.  Although really all most of them do is convert from typesafe to jackson.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: Streams 167

Posted by renato2099 <gi...@git.apache.org>.

Github user renato2099 commented on the pull request:

    https://github.com/apache/incubator-streams/pull/81#issuecomment-55227887
  
    Cool! So could anybody merge this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: Streams 167

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-streams/pull/81


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---