You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/06/27 09:16:48 UTC
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3505
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Add a test for the integration of RequestTracker with the client and ResultTracker with the server
This adds a test for the integration of the RequestTracker in the client
and the ResultTracker in the server. Specifically it tests that RetriableRpc
works in combination with replayed results from the ResultTracker and that
multiple simultaneous (similar) RPCs from the client are not executed more
than once.
Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
---
A src/kudu/rpc/rpc-stress-test.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rtest.proto
3 files changed, 365 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3505/1
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/2032/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2026/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 7:
Build Started http://104.196.14.100/job/kudu-gerrit/2130/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3505
to look at the new patch set (#5).
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Add a test for the integration of RequestTracker with the client and ResultTracker with the server
This adds a test for the integration of the RequestTracker in the client
and the ResultTracker in the server. Specifically it tests that RetriableRpc
works in combination with replayed results from the ResultTracker and that
multiple simultaneous (similar) RPCs from the client are not executed more
than once.
Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
---
A src/kudu/rpc/rpc-stress-test.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rtest.proto
3 files changed, 366 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3505/5
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 9:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3505/9/src/kudu/rpc/rpc-stress-test.cc
File src/kudu/rpc/rpc-stress-test.cc:
PS9, Line 143: very short timeout
> I dont see the very short timeout
old stuff, removed
Line 172: rpc_->SendRpc();
> where's the sleep? need to update some comments?
copy past artifact, removed
PS9, Line 207: random amount
> not random?
Done
http://gerrit.cloudera.org:8080/#/c/3505/9/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:
Line 273: context->RespondSuccess();
> would be good for this to randomly fail sometimes to test that code path
did this in when I added the client test to the client patch
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 5:
Build Started http://104.196.14.100/job/kudu-gerrit/2034/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 9:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3505/9//COMMIT_MSG
Commit Message:
Line 7: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
hrm, this commit message seems inaccurate - this is an RPC-system-only test, right?
http://gerrit.cloudera.org:8080/#/c/3505/9/src/kudu/rpc/rpc-stress-test.cc
File src/kudu/rpc/rpc-stress-test.cc:
PS9, Line 143: very short timeout
I dont see the very short timeout
Line 172: rpc_->SendRpc();
where's the sleep? need to update some comments?
PS9, Line 207: random amount
not random?
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2018/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 5: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2039/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 4: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2033/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3505
to look at the new patch set (#9).
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Add a test for the integration of RequestTracker with the client and ResultTracker with the server
This adds a test for the integration of the RequestTracker in the client
and the ResultTracker in the server. Specifically it tests that RetriableRpc
works in combination with replayed results from the ResultTracker and that
multiple simultaneous (similar) RPCs from the client are not executed more
than once.
Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
---
M src/kudu/rpc/CMakeLists.txt
A src/kudu/rpc/rpc-stress-test.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rtest.proto
4 files changed, 367 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3505/9
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has abandoned this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 6: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2048/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 8:
Build Started http://104.196.14.100/job/kudu-gerrit/2157/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2013/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3505
to look at the new patch set (#6).
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Add a test for the integration of RequestTracker with the client and ResultTracker with the server
This adds a test for the integration of the RequestTracker in the client
and the ResultTracker in the server. Specifically it tests that RetriableRpc
works in combination with replayed results from the ResultTracker and that
multiple simultaneous (similar) RPCs from the client are not executed more
than once.
Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
---
M src/kudu/rpc/CMakeLists.txt
A src/kudu/rpc/rpc-stress-test.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rtest.proto
4 files changed, 367 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3505/6
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 9:
Build Started http://104.196.14.100/job/kudu-gerrit/2188/
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3505/9/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:
Line 273: context->RespondSuccess();
would be good for this to randomly fail sometimes to test that code path
--
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes