You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/10/14 10:03:53 UTC

Review Request 39310: Enable /master/state-summary endpoint include active flag for framework

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39310/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-3721
    https://issues.apache.org/jira/browse/MESOS-3721


Repository: mesos


Description
-------

Enable /master/state-summary endpoint include active flag for framework


Diffs
-----

  src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 

Diff: https://reviews.apache.org/r/39310/diff/


Testing
-------

gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/state-summary" 2>/dev/null| jq .
{
  "slaves": [
    {
      "used_resources": {
        "mem": 256,
        "disk": 0,
        "cpus": 1
      },
      "unreserved_resources": {
        "ports": "[31000-32000]",
        "mem": 2808,
        "disk": 1399183,
        "cpus": 4
      },
      "resources": {
        "ports": "[31000-32000]",
        "mem": 2808,
        "disk": 1399183,
        "cpus": 4
      },
      "reserved_resources": {},
      "reregistered_time": 1444809313.03239,
      "TASK_STARTING": 0,
      "TASK_STAGING": 0,
      "TASK_RUNNING": 1,
      "TASK_LOST": 0,
      "TASK_KILLED": 0,
      "TASK_FINISHED": 0,
      "TASK_FAILED": 0,
      "TASK_ERROR": 0,
      "active": true,
      "attributes": {},
      "framework_ids": [
        "ec7faf83-1838-4909-9a96-4e30a6757967-0000"
      ],
      "hostname": "devstack007.cn.ibm.com",
      "id": "2a7e51b2-20d2-4476-a3e3-8c3207e7427a-S0",
      "offered_resources": {
        "mem": 0,
        "disk": 0,
        "cpus": 0
      },
      "pid": "slave(1)@9.111.242.187:5051",
      "registered_time": 1444809313.03176
    }
  ],
  "hostname": "devstack007.cn.ibm.com",
  "frameworks": [
    {
      "webui_url": "",
      "used_resources": {
        "mem": 256,
        "disk": 0,
        "cpus": 1
      },
      "TASK_STARTING": 0,
      "TASK_STAGING": 0,
      "TASK_RUNNING": 1,
      "TASK_LOST": 0,
      "TASK_KILLED": 0,
      "TASK_FINISHED": 0,
      "TASK_FAILED": 0,
      "TASK_ERROR": 0,
      "active": true, <<<<<<<<<<<< Here
      "capabilities": [],
      "hostname": "devstack007.cn.ibm.com",
      "id": "ec7faf83-1838-4909-9a96-4e30a6757967-0000",
      "name": "",
      "offered_resources": {
        "mem": 0,
        "disk": 0,
        "cpus": 0
      },
      "pid": "scheduler-b68990a9-aed9-4182-bacb-456cbb7302d6@9.111.242.187:34782",
      "slave_ids": [
        "2a7e51b2-20d2-4476-a3e3-8c3207e7427a-S0"
      ]
    }
  ]
}


Thanks,

Guangya Liu


Re: Review Request 39310: Enable /master/state-summary endpoint include active flag for framework

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39310/#review102599
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39310]

All tests passed.

- Mesos ReviewBot


On Oct. 14, 2015, 8:03 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39310/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 8:03 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3721
>     https://issues.apache.org/jira/browse/MESOS-3721
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable /master/state-summary endpoint include active flag for framework
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
> 
> Diff: https://reviews.apache.org/r/39310/diff/
> 
> 
> Testing
> -------
> 
> gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/state-summary" 2>/dev/null| jq .
> {
>   "slaves": [
>     {
>       "used_resources": {
>         "mem": 256,
>         "disk": 0,
>         "cpus": 1
>       },
>       "unreserved_resources": {
>         "ports": "[31000-32000]",
>         "mem": 2808,
>         "disk": 1399183,
>         "cpus": 4
>       },
>       "resources": {
>         "ports": "[31000-32000]",
>         "mem": 2808,
>         "disk": 1399183,
>         "cpus": 4
>       },
>       "reserved_resources": {},
>       "reregistered_time": 1444809313.03239,
>       "TASK_STARTING": 0,
>       "TASK_STAGING": 0,
>       "TASK_RUNNING": 1,
>       "TASK_LOST": 0,
>       "TASK_KILLED": 0,
>       "TASK_FINISHED": 0,
>       "TASK_FAILED": 0,
>       "TASK_ERROR": 0,
>       "active": true,
>       "attributes": {},
>       "framework_ids": [
>         "ec7faf83-1838-4909-9a96-4e30a6757967-0000"
>       ],
>       "hostname": "devstack007.cn.ibm.com",
>       "id": "2a7e51b2-20d2-4476-a3e3-8c3207e7427a-S0",
>       "offered_resources": {
>         "mem": 0,
>         "disk": 0,
>         "cpus": 0
>       },
>       "pid": "slave(1)@9.111.242.187:5051",
>       "registered_time": 1444809313.03176
>     }
>   ],
>   "hostname": "devstack007.cn.ibm.com",
>   "frameworks": [
>     {
>       "webui_url": "",
>       "used_resources": {
>         "mem": 256,
>         "disk": 0,
>         "cpus": 1
>       },
>       "TASK_STARTING": 0,
>       "TASK_STAGING": 0,
>       "TASK_RUNNING": 1,
>       "TASK_LOST": 0,
>       "TASK_KILLED": 0,
>       "TASK_FINISHED": 0,
>       "TASK_FAILED": 0,
>       "TASK_ERROR": 0,
>       "active": true, <<<<<<<<<<<< Here
>       "capabilities": [],
>       "hostname": "devstack007.cn.ibm.com",
>       "id": "ec7faf83-1838-4909-9a96-4e30a6757967-0000",
>       "name": "",
>       "offered_resources": {
>         "mem": 0,
>         "disk": 0,
>         "cpus": 0
>       },
>       "pid": "scheduler-b68990a9-aed9-4182-bacb-456cbb7302d6@9.111.242.187:34782",
>       "slave_ids": [
>         "2a7e51b2-20d2-4476-a3e3-8c3207e7427a-S0"
>       ]
>     }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 39310: Enable /master/state-summary endpoint include active flag for framework

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39310/#review102678
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 14, 2015, 8:03 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39310/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 8:03 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3721
>     https://issues.apache.org/jira/browse/MESOS-3721
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable /master/state-summary endpoint include active flag for framework
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
> 
> Diff: https://reviews.apache.org/r/39310/diff/
> 
> 
> Testing
> -------
> 
> gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/state-summary" 2>/dev/null| jq .
> {
>   "slaves": [
>     {
>       "used_resources": {
>         "mem": 256,
>         "disk": 0,
>         "cpus": 1
>       },
>       "unreserved_resources": {
>         "ports": "[31000-32000]",
>         "mem": 2808,
>         "disk": 1399183,
>         "cpus": 4
>       },
>       "resources": {
>         "ports": "[31000-32000]",
>         "mem": 2808,
>         "disk": 1399183,
>         "cpus": 4
>       },
>       "reserved_resources": {},
>       "reregistered_time": 1444809313.03239,
>       "TASK_STARTING": 0,
>       "TASK_STAGING": 0,
>       "TASK_RUNNING": 1,
>       "TASK_LOST": 0,
>       "TASK_KILLED": 0,
>       "TASK_FINISHED": 0,
>       "TASK_FAILED": 0,
>       "TASK_ERROR": 0,
>       "active": true,
>       "attributes": {},
>       "framework_ids": [
>         "ec7faf83-1838-4909-9a96-4e30a6757967-0000"
>       ],
>       "hostname": "devstack007.cn.ibm.com",
>       "id": "2a7e51b2-20d2-4476-a3e3-8c3207e7427a-S0",
>       "offered_resources": {
>         "mem": 0,
>         "disk": 0,
>         "cpus": 0
>       },
>       "pid": "slave(1)@9.111.242.187:5051",
>       "registered_time": 1444809313.03176
>     }
>   ],
>   "hostname": "devstack007.cn.ibm.com",
>   "frameworks": [
>     {
>       "webui_url": "",
>       "used_resources": {
>         "mem": 256,
>         "disk": 0,
>         "cpus": 1
>       },
>       "TASK_STARTING": 0,
>       "TASK_STAGING": 0,
>       "TASK_RUNNING": 1,
>       "TASK_LOST": 0,
>       "TASK_KILLED": 0,
>       "TASK_FINISHED": 0,
>       "TASK_FAILED": 0,
>       "TASK_ERROR": 0,
>       "active": true, <<<<<<<<<<<< Here
>       "capabilities": [],
>       "hostname": "devstack007.cn.ibm.com",
>       "id": "ec7faf83-1838-4909-9a96-4e30a6757967-0000",
>       "name": "",
>       "offered_resources": {
>         "mem": 0,
>         "disk": 0,
>         "cpus": 0
>       },
>       "pid": "scheduler-b68990a9-aed9-4182-bacb-456cbb7302d6@9.111.242.187:34782",
>       "slave_ids": [
>         "2a7e51b2-20d2-4476-a3e3-8c3207e7427a-S0"
>       ]
>     }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>