You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/13 22:47:51 UTC
[GitHub] [airflow] OyinOlamide opened a new pull request #19577: Edits
OyinOlamide opened a new pull request #19577:
URL: https://github.com/apache/airflow/pull/19577
Hello @potiuk @eladkal , I am Oyinkansola Awosan, Outreachy applicant for December 2021 to March 2022 round. My last pull request had some issues I couldn't quite figure out so I decided to work on it all over again, make a fresh PR and close the other one.
I tried my hands on the better variable naming issue, I do not think this PR is perfect, I would however like corrections, what I have done wrong and can do so I can make better changes and get the entire issue solved.
Thank you!
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #19577: Edits
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #19577:
URL: https://github.com/apache/airflow/pull/19577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19577: Edits
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19577:
URL: https://github.com/apache/airflow/pull/19577#issuecomment-970427764
Hmm. Actually, those changes are not good, I am afraid. Re-looked at it. Those variables are supposed to be CAPITALIZED because they are part of the "API" for the prod image and they could be set from outside: https://airflow.apache.org/docs/docker-stack/entrypoint.html#waits-for-airflow-db-connection - sorry for the confusion.
Closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #19577: Edits
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #19577:
URL: https://github.com/apache/airflow/pull/19577#discussion_r750034853
##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -304,14 +304,16 @@ exec_to_bash_or_python_command_if_specified "${@}"
# docker run IMAGE airflow webserver
# docker run IMAGE webserver
#
+
+
if [[ ${AIRFLOW_COMMAND} == "airflow" ]]; then
AIRFLOW_COMMAND="${2:-}"
shift
fi
# Note: the broker backend configuration concerns only a subset of Airflow components
if [[ ${AIRFLOW_COMMAND} =~ ^(scheduler|celery)$ ]] \
- && [[ "${CONNECTION_CHECK_MAX_COUNT}" -gt "0" ]]; then
+ && [[ "${cticonneon_check_max_count}" -gt "0" ]]; then
Review comment:
```suggestion
&& [[ "${connection_check_max_count}" -gt "0" ]]; then
```
probably ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19577: Edits
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19577:
URL: https://github.com/apache/airflow/pull/19577#issuecomment-970355899
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OyinOlamide commented on pull request #19577: Edits
Posted by GitBox <gi...@apache.org>.
OyinOlamide commented on pull request #19577:
URL: https://github.com/apache/airflow/pull/19577#issuecomment-970346441
Thank you @eladkal That was a mistake on my path.
Please aside from this, is every other thing correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org