[GitHub] [helix] pkuwm opened a new issue #1461: Thread Leakage in TestWagedRebalancerMetrics#setupClusterDataCache

[GitBox <gi...@apache.org>]

pkuwm opened a new issue #1461:
URL: https://github.com/apache/helix/issues/1461


   ### Describe the bug
   In `TestWagedRebalancerMetrics.setupClusterDataCache()`, threadExcecutor is not properly shutdown after the test method.
   ```
   when(testCache.getAsyncTasksThreadPool()).thenReturn(Executors.newSingleThreadExecutor());
   ```
   
   ### To Reproduce
   Run TestWagedRebalancerMetrics
   
   ### Expected behavior
   The thread pool created by `Executors.newSingleThreadExecutor()` should be shutdown.
   
   ### Additional context
   We can create a singleton threadpool in the abstract class and then after the test, the singleton thread pool should be shutdown.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org