You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/26 20:45:18 UTC

[GitHub] [pulsar] devinbost opened a new pull request #10389: Completed work for PR #7555 to allow customizable function logging

devinbost opened a new pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389


   This PR completes the work started by @g0715158 in PR #7555 to allow customization of the Pulsar function log level. 
   I created a new PR because it looked like the branch for that repo (`g0715158:master`) involved a change for a different issue, and Github indicated the repo had been deleted. (I was unable to find the original commits on that repo in a branch.) 
   
   @g0715158 Please let me know if you'd like to create a branch with your changes so you can get credit for your work. (In that case, I'll delete this PR and add my commits to your branch.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-827336974


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-841958964


   Hi @devinbost thanks for your great work. I'm adding docs for this PR but have some questions documented [here](https://docs.google.com/document/d/1FgeagvB7Nqefe5zxu--wKlEYzr3OoiOp3dWvEGGSRjM/edit), could you please take a look? Many thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-842809069


   @devinbost many thanks for your contribution. I've reviewed your doc PR, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-827892071


   I tested this in production, and it works great. 
   @merlimat @sijie ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-830607708


   @eolivelli Yes, this applies to branch-2.7 and doesn't have any other dependencies. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-831043069


   cherry picked to branch-2.7 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-827209682


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-827302463


   @eolivelli I made some additional changes to make this feature more robust. Please review the new changes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-842679138


   @Anonymitaet Please see #10617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jerrypeng merged pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
jerrypeng merged pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-841958964


   Hi @devinbost thanks for your great work. I'm adding docs for this PR but have some questions documented [here](https://docs.google.com/document/d/1FgeagvB7Nqefe5zxu--wKlEYzr3OoiOp3dWvEGGSRjM/edit), could you please take a look? Many thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-827275642


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-827136704


   Please verify these changes @jerrypeng @cdbartholomew @vaihtovirta @eolivelli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-830569676


   @devinbost will this patch apply to branch-2.7?
   
   Or does it need some dependencies?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] devinbost commented on pull request #10389: [Functions] Completed work for PR #7555 to allow customizable function logging

Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10389:
URL: https://github.com/apache/pulsar/pull/10389#issuecomment-842590614


   @Anonymitaet Thanks for your help with the docs. I'll get this taken care of today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org