You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 15:45:39 UTC
[GitHub] [airflow] raphaelauv opened a new pull request #21902: [FEATURE] remove K8S 1.20 support
raphaelauv opened a new pull request #21902:
URL: https://github.com/apache/airflow/pull/21902
Support of K8S 1.20 ended yesterday -> https://endoflife.date/kubernetes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21902:
URL: https://github.com/apache/airflow/pull/21902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060801295
But if you use a EKS or GKE , updating your K8S cluster is easy and fully managed by the cloud provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21902: [FEATURE] remove K8S 1.20 support
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060056002
> End of life from Kube project, but still supported in Amazon EKS https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html and https://cloud.google.com/kubernetes-engine/docs/release-schedule
Hmm. Do we care actually ? Similarly as Python, we agreed to follow K8S EOL not EKS EOL.
I am not talking that we shoul not do it, but if we should, possibly we should have a rule describing it . Do we care about EKS? GKS? others? What would be the reasoning here?
Currently the change is very much in line with our rules: https://github.com/apache/airflow/blob/main/README.md#support-for-python-and-kubernetes-versions
And I would even say it should be accompanied by adding 1.22 and and 1.23 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060815351
> > But if you use a EKS or GKE , updating your K8S cluster is easy and fully managed by the cloud provider
>
> "Hi Central Infra Team? Yes I'd you you to upgrade our kubernetes cluster so I can update my app". There are plenty of companies where it would not play out well.
Can you raise it at the devlist @ashb - this is a change to what we agreed to, so I think it should make it into a discussion in the devlist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060803703
> But if you use a EKS or GKE , updating your K8S cluster is easy and fully managed by the cloud provider
"Hi Central Infra Team? Yes I'd you you to upgrade our kubernetes cluster so I can update my app". There are plenty of companies where it would not play out well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] add 1.22 1.23 K8S support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1073000463
The Kubernetes Upgrade for all the versions takes more than 80m so you should increase it in the `ci.yml` - it woudl be great to add the rule above to README in the same PR @raphaelauv :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060504717
Random failure on image building
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21902:
URL: https://github.com/apache/airflow/pull/21902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1068943744
As discussed in https://lists.apache.org/thread/fr3tdy4nc8ywo3p0hpy9h04nyv1kldsy (which seems to be agreed - both by lazy consensus and voting) - we should leave 1.20 as supported.
Maybe that is a good idea @raphaelauv to update this together with updating the rule as proposed by @ashb - that we support end-of-life K8S versions "as long as it is supported by at least two major clouds". That means that we will be able to remove 1.20 in August when GCP drops the support.
https://github.com/apache/airflow/blob/main/README.md#support-for-python-and-kubernetes-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060796604
In this case yes, I care a lot more. Updating python version for a single application is a lot easier than upgrading a whole cluster.
By doing this we make it that much harder for users to update.
So -1 to the removal of 1.20 while the big cloud providers still support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060820798
Just to make it here - it was agreed here by the lazy consensus: https://lists.apache.org/thread/3m6hfxfhfhvo14kmhc38s2fgz1jfgz0y
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060825523
And to be perfectly clear. I think indeed it makes sense to keep it a bit longer but we need to propose some rules for it :). For example support by major K8S cluster providers might be a good rule to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] remove K8S 1.20 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060056002
> End of life from Kube project, but still supported in Amazon EKS https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html and https://cloud.google.com/kubernetes-engine/docs/release-schedule
Hmm. Do we care actually ? Similarly as Python, we agreed to follow K8S EOL not EKS EOL.
I am not talking that we shoul not do it, but if we should possibly we should have a rule describing it . Do we care about EKS? GKS? others? What would be the reasoning here?
Currently the change is very much in line with our rules: https://github.com/apache/airflow/blob/main/README.md#support-for-python-and-kubernetes-versions
(And I would even say it should be accompanied by addign 1.22 and and 1.23 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] add 1.22 1.23 K8S support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1074384321
Looks good - just a flaky test failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21902: [FEATURE] add 1.22 1.23 K8S support
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21902:
URL: https://github.com/apache/airflow/pull/21902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #21902: [FEATURE] remove K8S 1.20 support
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1055897458
End of life from Kube project, but still supported in Amazon EKS https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html and https://cloud.google.com/kubernetes-engine/docs/release-schedule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060825523
And to be perfectly clear. I think indeed it makes sense to keep it a bit longer but we need to propos some rules for it :). For example support by major K8S cluster providers might be a good rule to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21902: [FEATURE] remove K8S 1.20 and add 1.22 1.23 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060424234
Added "full tests needed" and closed/reopened to trigger test for more complete matrix combination
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21902: [FEATURE] remove K8S 1.20 support
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1060056002
> End of life from Kube project, but still supported in Amazon EKS https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html and https://cloud.google.com/kubernetes-engine/docs/release-schedule
Hmm. Do we care actually ? Similarly as Python, we agreed to follow K8S EOL not EKS EOL.
I am not talking that we shoul not do it, but if we should, possibly we should have a rule describing it . Do we care about EKS? GKS? others? What would be the reasoning here?
Currently the change is very much in line with our rules: https://github.com/apache/airflow/blob/main/README.md#support-for-python-and-kubernetes-versions
(And I would even say it should be accompanied by addign 1.22 and and 1.23 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #21902: [FEATURE] add 1.22 1.23 K8S support
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on pull request #21902:
URL: https://github.com/apache/airflow/pull/21902#issuecomment-1074377405
@potiuk I've made the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org