You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/18 11:47:29 UTC

[GitHub] [airflow] robinedwards opened a new pull request #6839: [AIRFLOW-6268] Prevent ajax calls when no dags present

robinedwards opened a new pull request #6839: [AIRFLOW-6268] Prevent ajax calls when no dags present
URL: https://github.com/apache/airflow/pull/6839
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-6268
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   When searching for DAGs in the UI and no results are returned four AJAX requests are still issued (dag_stats, task_stasks, blocked and last_dagruns) which return the state of the entire the system.
   
   This small changes prevents the AJAX requests being issued when there are no DAGs on the page.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   N/A no unit tests for frontend code at present. Tested locally.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services