You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by fi...@apache.org on 2009/01/30 03:48:08 UTC
svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Author: fielding
Date: Fri Jan 30 02:48:08 2009
New Revision: 739150
URL: http://svn.apache.org/viewvc?rev=739150&view=rev
Log:
revert r711228: the ap_unixd_setup_child prototype needs to go somewhere.
Modified:
httpd/httpd/trunk/os/unix/unixd.h
Modified: httpd/httpd/trunk/os/unix/unixd.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/os/unix/unixd.h?rev=739150&r1=739149&r2=739150&view=diff
==============================================================================
--- httpd/httpd/trunk/os/unix/unixd.h (original)
+++ httpd/httpd/trunk/os/unix/unixd.h Fri Jan 30 02:48:08 2009
@@ -80,6 +80,8 @@
} unixd_config_rec;
AP_DECLARE_DATA extern unixd_config_rec ap_unixd_config;
+AP_DECLARE(int) ap_unixd_setup_child(void); /* mod_cgid needs this */
+
#if defined(RLIMIT_CPU) || defined(RLIMIT_DATA) || defined(RLIMIT_VMEM) || defined(RLIMIT_NPROC) || defined(RLIMIT_AS)
AP_DECLARE(void) ap_unixd_set_rlimit(cmd_parms *cmd, struct rlimit **plimit,
const char *arg,
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by Ruediger Pluem <rp...@apache.org>.
On 01/31/2009 04:17 AM, Nick Kew wrote:
> Paul Querna wrote:
>
>> imo, no one uses these mpms, we should delete them.
>
> ISTR having this conversation ahead of 2.2. We deleted
> them from 2.2 but left them in trunk for posterity,
> and in case anyone felt like picking it up.
>
> They look like obvious candidates for an attic now.
+1 on removing them. They are unmaintained since I am
around since 2005. As subversion does not lose anything
let us simply remove them. If someone is interested again
he can pick them up from an old revision / tag.
Regards
Rüdiger
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by Issac Goldstand <ma...@beamartyr.net>.
Nick Kew wrote:
> Paul Querna wrote:
>
>> imo, no one uses these mpms, we should delete them.
>
> ISTR having this conversation ahead of 2.2. We deleted
> them from 2.2 but left them in trunk for posterity,
> and in case anyone felt like picking it up.
>
> They look like obvious candidates for an attic now.
>
+1
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by Nick Kew <ni...@webthing.com>.
Paul Querna wrote:
> imo, no one uses these mpms, we should delete them.
ISTR having this conversation ahead of 2.2. We deleted
them from 2.2 but left them in trunk for posterity,
and in case anyone felt like picking it up.
They look like obvious candidates for an attic now.
--
Nick Kew
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by Paul Querna <ch...@force-elite.com>.
Roy T. Fielding wrote:
> On Jan 30, 2009, at 3:30 PM, Roy T. Fielding wrote:
>> On Jan 30, 2009, at 3:07 PM, Ruediger Pluem wrote:
>>> On 01/30/2009 03:48 AM, fielding@apache.org wrote:
>>>> +AP_DECLARE(int) ap_unixd_setup_child(void); /* mod_cgid needs this */
>>>> +
>>>
>>> Hm. This break compilation of trunk as this symbol is now added to
>>> exports.c again
>>> with no implementation in the core (only in a module).
>>
>> It doesn't break my compilation in trunk -- I've done two complete
>> builds since then with no problems. Which platform and MPM? I have
>> been testing OS X 10.4.11 with prefork.
>
> Let me know if r739487 fixes it. My guess is that the three
> old MPMs (leader, perchild, threadpool) still don't work, but
> I don't want to fix them if we are just going to delete them.
>
> It bothers me that I really have no idea if this code even
> works, given that it is supposedly the heart of a seteuid
> switching child (or some such). I would really appreciate
> it if someone who actually uses this stuff could decide
> what should be deleted *before* we release it.
imo, no one uses these mpms, we should delete them.
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by Ruediger Pluem <rp...@apache.org>.
On 01/31/2009 02:59 AM, Roy T. Fielding wrote:
> On Jan 30, 2009, at 3:30 PM, Roy T. Fielding wrote:
>> On Jan 30, 2009, at 3:07 PM, Ruediger Pluem wrote:
>>> On 01/30/2009 03:48 AM, fielding@apache.org wrote:
>>>> +AP_DECLARE(int) ap_unixd_setup_child(void); /* mod_cgid needs this */
>>>> +
>>>
>>> Hm. This break compilation of trunk as this symbol is now added to
>>> exports.c again
>>> with no implementation in the core (only in a module).
>>
>> It doesn't break my compilation in trunk -- I've done two complete
>> builds since then with no problems. Which platform and MPM? I have
>> been testing OS X 10.4.11 with prefork.
Linux and worker.
>
> Let me know if r739487 fixes it. My guess is that the three
Yes this fixes it. Thanks.
Regards
Rüdiger
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by Nick Kew <ni...@webthing.com>.
Roy T. Fielding wrote:
> It bothers me that I really have no idea if this code even
> works, given that it is supposedly the heart of a seteuid
> switching child (or some such). I would really appreciate
> it if someone who actually uses this stuff could decide
> what should be deleted *before* we release it.
We aren't going to release leader/perchild/threadpool.
If that ever changes, it has to be because at least one
committer is doing real work on it. Including sorting
out issues like dropping privileges.
--
Nick Kew
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by "Roy T. Fielding" <fi...@gbiv.com>.
On Jan 30, 2009, at 3:30 PM, Roy T. Fielding wrote:
> On Jan 30, 2009, at 3:07 PM, Ruediger Pluem wrote:
>> On 01/30/2009 03:48 AM, fielding@apache.org wrote:
>>> +AP_DECLARE(int) ap_unixd_setup_child(void); /* mod_cgid needs
>>> this */
>>> +
>>
>> Hm. This break compilation of trunk as this symbol is now added to
>> exports.c again
>> with no implementation in the core (only in a module).
>
> It doesn't break my compilation in trunk -- I've done two complete
> builds since then with no problems. Which platform and MPM? I have
> been testing OS X 10.4.11 with prefork.
Let me know if r739487 fixes it. My guess is that the three
old MPMs (leader, perchild, threadpool) still don't work, but
I don't want to fix them if we are just going to delete them.
It bothers me that I really have no idea if this code even
works, given that it is supposedly the heart of a seteuid
switching child (or some such). I would really appreciate
it if someone who actually uses this stuff could decide
what should be deleted *before* we release it.
....Roy
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by "Roy T. Fielding" <fi...@gbiv.com>.
On Jan 30, 2009, at 3:07 PM, Ruediger Pluem wrote:
> On 01/30/2009 03:48 AM, fielding@apache.org wrote:
>> Author: fielding
>> Date: Fri Jan 30 02:48:08 2009
>> New Revision: 739150
>>
>> URL: http://svn.apache.org/viewvc?rev=739150&view=rev
>> Log:
>> revert r711228: the ap_unixd_setup_child prototype needs to go
>> somewhere.
>>
>> Modified:
>> httpd/httpd/trunk/os/unix/unixd.h
>>
>> Modified: httpd/httpd/trunk/os/unix/unixd.h
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/os/unix/
>> unixd.h?rev=739150&r1=739149&r2=739150&view=diff
>> =====================================================================
>> =========
>> --- httpd/httpd/trunk/os/unix/unixd.h (original)
>> +++ httpd/httpd/trunk/os/unix/unixd.h Fri Jan 30 02:48:08 2009
>> @@ -80,6 +80,8 @@
>> } unixd_config_rec;
>> AP_DECLARE_DATA extern unixd_config_rec ap_unixd_config;
>>
>> +AP_DECLARE(int) ap_unixd_setup_child(void); /* mod_cgid needs
>> this */
>> +
>
> Hm. This break compilation of trunk as this symbol is now added to
> exports.c again
> with no implementation in the core (only in a module).
It doesn't break my compilation in trunk -- I've done two complete
builds since then with no problems. Which platform and MPM? I have
been testing OS X 10.4.11 with prefork.
> Where did it break with -Werror prior to this change?
Where it is first defined:
modules/arch/unix/mod_unixd.c
306:AP_DECLARE(int) ap_unixd_setup_child(void)
Note that the function is only called in a few old MPMs:
server/mpm/experimental/leader/leader.c
1023: if (ap_unixd_setup_child()) {
server/mpm/experimental/perchild/perchild.c
862: return ap_unixd_setup_child();
server/mpm/experimental/threadpool/threadpool.c
1246: if (ap_unixd_setup_child()) {
Can we move the function into those MPMs and just make it static?
Or maybe mpm_common.h?
....Roy
Re: svn commit: r739150 - /httpd/httpd/trunk/os/unix/unixd.h
Posted by Ruediger Pluem <rp...@apache.org>.
On 01/30/2009 03:48 AM, fielding@apache.org wrote:
> Author: fielding
> Date: Fri Jan 30 02:48:08 2009
> New Revision: 739150
>
> URL: http://svn.apache.org/viewvc?rev=739150&view=rev
> Log:
> revert r711228: the ap_unixd_setup_child prototype needs to go somewhere.
>
> Modified:
> httpd/httpd/trunk/os/unix/unixd.h
>
> Modified: httpd/httpd/trunk/os/unix/unixd.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/os/unix/unixd.h?rev=739150&r1=739149&r2=739150&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/os/unix/unixd.h (original)
> +++ httpd/httpd/trunk/os/unix/unixd.h Fri Jan 30 02:48:08 2009
> @@ -80,6 +80,8 @@
> } unixd_config_rec;
> AP_DECLARE_DATA extern unixd_config_rec ap_unixd_config;
>
> +AP_DECLARE(int) ap_unixd_setup_child(void); /* mod_cgid needs this */
> +
Hm. This break compilation of trunk as this symbol is now added to exports.c again
with no implementation in the core (only in a module).
Where did it break with -Werror prior to this change?
Regards
Rüdiger