You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2022/10/31 18:29:00 UTC

[jira] [Commented] (CALCITE-5356) Update junit4 to 4.13.2 and junit5 to 5.9.1

    [ https://issues.apache.org/jira/browse/CALCITE-5356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626749#comment-17626749 ] 

Julian Hyde commented on CALCITE-5356:
--------------------------------------

What changed in junit that made this stop working?

The {{getPath}} method needs javadoc, and needs {{\@Override}} annotations

> Update junit4 to 4.13.2 and junit5 to 5.9.1
> -------------------------------------------
>
>                 Key: CALCITE-5356
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5356
>             Project: Calcite
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> junit4 to 4.13.2
> junit5 to 5.9.1
> It seems there is an issue with {{org.apache.calcite.test.QuidemTest#data}}
> The idea is to make test per class and parameterized method abstract/implemented in each test



--
This message was sent by Atlassian Jira
(v8.20.10#820010)