You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/07 15:19:52 UTC

[GitHub] [spark] srowen commented on issue #27491: [SPARK-30754][SQL] Reuse results of floorDiv in calculations of floorMod in DateTimeUtils

srowen commented on issue #27491: [SPARK-30754][SQL] Reuse results of floorDiv in calculations of floorMod in DateTimeUtils
URL: https://github.com/apache/spark/pull/27491#issuecomment-583448566
 
 
   It's pretty trivially faster, I'd imagine, but the logic looks sound and it's not more complex

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org