You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/07 20:14:12 UTC
[GitHub] [camel] FAnett1997 opened a new pull request #4575: Code maintainability by QualityGate
FAnett1997 opened a new pull request #4575:
URL: https://github.com/apache/camel/pull/4575
With the new code maintainability diagram (by QualityGate) you are able to monitor the quality changes of your source code - all those metrics, code duplications and numerous other factors which have a direct impact on maintainability of your application.
_New features are available:_
- Team performance, developer statistics
- Code smells based on the detected code duplications
- Code advisor, the most refactorable points of the system
For more details, please visit: https://quality-gate.com/dashboard/branches/48#overview
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4575: Code maintainability by QualityGate
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4575:
URL: https://github.com/apache/camel/pull/4575#issuecomment-725387206
Lets close this. If anybody is interested we can re-open it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4575: Code maintainability by QualityGate
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4575:
URL: https://github.com/apache/camel/pull/4575#issuecomment-723999929
> I don't know what the other think about this, but I think static analyzer are useless
My .2 cents: I think they need to be properly configured by someone that has some understanding of the code base otherwise you get a lot of false positives. In my case, I do make use of one, but I did invest some time - and still am investing - to configure it to find problems and patterns that are valid. It also takes some time to get used to it, in order to avoid the data to "rot" there and become invalid.
Personally, I would avoid adding a bare report analysis for Camel without further thought, configuration and analysis of what problems and patterns the code base is prune to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd closed pull request #4575: Code maintainability by QualityGate
Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #4575:
URL: https://github.com/apache/camel/pull/4575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske edited a comment on pull request #4575: Code maintainability by QualityGate
Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on pull request #4575:
URL: https://github.com/apache/camel/pull/4575#issuecomment-723999929
> I don't know what the other think about this, but I think static analyzer are useless
My .2 cents: I think they need to be properly configured by someone that has some understanding of the code base otherwise you get a lot of false positives. In my case, I do make use of one, but I did invest some time - and still am investing - to configure it to find problems and patterns that are valid. It also takes some time to get used to it, in order to avoid the data to "rot" there and become invalid.
Personally, I would avoid adding a bare report analysis for Camel without further thought, configuration and analysis of what problems and patterns the code base is prone to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org