You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jianran <gi...@git.apache.org> on 2017/03/16 07:13:32 UTC
[GitHub] spark pull request #17309: same rdd rule testcase
GitHub user jianran opened a pull request:
https://github.com/apache/spark/pull/17309
same rdd rule testcase
## What changes were proposed in this pull request?
I improvise and change the testcase because rdd_0_2 didn't removed is because of same rdd-rule not because of rdd_0_2 is the most recently used item
## How was this patch tested?
run the changed testcase
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jianran/spark samerddrule
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17309
----
commit 2710de064ee3cad8c5db117f8fd4b1a984303b1e
Author: jianran.tfh <ji...@taobao.com>
Date: 2017-03-16T07:05:28Z
same rdd rule testcase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17309: same rdd rule testcase
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17309
See http://spark.apache.org/contributing.html
I'm not clear this adds any value?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17309: same rdd rule testcase
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17309
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17309: same rdd rule testcase
Posted by jianran <gi...@git.apache.org>.
Github user jianran closed the pull request at:
https://github.com/apache/spark/pull/17309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org