[GitHub] [calcite] helloppx commented on a change in pull request #1680: [CALCITE-3621] Push down sort to DB, SQL of Sort rel contains explicit field name instead of *

[GitBox <gi...@apache.org>]

helloppx commented on a change in pull request #1680: [CALCITE-3621] Push down sort to DB, SQL of Sort rel contains explicit field name instead of *
URL: https://github.com/apache/calcite/pull/1680#discussion_r360749347
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
 ##########
 @@ -765,10 +766,11 @@ public RelNode convert(RelNode rel) {
      */
     public RelNode convert(Sort sort, boolean convertInputTraits) {
       final RelTraitSet traitSet = sort.getTraitSet().replace(out);
+      RelTraitSet inputTraitSet = traitSet.replace(RelCollations.EMPTY);
 
 Review comment:
   Yes, your change is better :D

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services