You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/15 22:18:24 UTC
[GitHub] [lucene-solr-operator] anshumg opened a new pull request #186: Cleanup README.md
anshumg opened a new pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186
Fix Bloomberg references.
Things pending:
- Docker Pulls - need to wait until we push an image to docker hub
- Slack - should we cross ref the Lucene/Solr one too?
- Contributing Guidelines - should we link this here? https://cwiki.apache.org/confluence/display/solr/HowToContribute ? This isn’t a 100% correct considering building and running are completely different for the operator. We need a new doc for this perhaps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg commented on a change in pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186#discussion_r558631487
##########
File path: README.md
##########
@@ -120,23 +121,15 @@ Have you had a good experience with the **Solr Operator**? Why not share some lo
We welcome issue reports [here](../../issues); be sure to choose the proper issue template for your issue, so that we can be sure you're providing the necessary information.
-Before sending a [Pull Request](../../pulls), please make sure you read our
-[Contribution Guidelines](https://github.com/bloomberg/.github/blob/master/CONTRIBUTING.md).
-
## License
Please read the [LICENSE](LICENSE) file here.
-## Code of Conduct
Review comment:
@HoustonPutman - we shouldn't add any non-ASF communication channels here as they aren't official.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg merged pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
anshumg merged pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186#issuecomment-761231504
And agreed on the docker images, that should be a separate PR entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg merged pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
anshumg merged pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186#issuecomment-761231254
I agree we should have a separate HowToContribute for the operator. I have some basic dev documentation, but it's not complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] klaporte commented on a change in pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
klaporte commented on a change in pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186#discussion_r558629682
##########
File path: README.md
##########
@@ -120,23 +121,15 @@ Have you had a good experience with the **Solr Operator**? Why not share some lo
We welcome issue reports [here](../../issues); be sure to choose the proper issue template for your issue, so that we can be sure you're providing the necessary information.
-Before sending a [Pull Request](../../pulls), please make sure you read our
-[Contribution Guidelines](https://github.com/bloomberg/.github/blob/master/CONTRIBUTING.md).
-
## License
Please read the [LICENSE](LICENSE) file here.
-## Code of Conduct
Review comment:
What about this? https://www.apache.org/foundation/policies/conduct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186#discussion_r558628525
##########
File path: README.md
##########
@@ -120,23 +121,15 @@ Have you had a good experience with the **Solr Operator**? Why not share some lo
We welcome issue reports [here](../../issues); be sure to choose the proper issue template for your issue, so that we can be sure you're providing the necessary information.
-Before sending a [Pull Request](../../pulls), please make sure you read our
-[Contribution Guidelines](https://github.com/bloomberg/.github/blob/master/CONTRIBUTING.md).
-
## License
Please read the [LICENSE](LICENSE) file here.
-## Code of Conduct
Review comment:
Is there no Apache code of conduct we can use here instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg commented on a change in pull request #186: Cleanup README.md
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #186:
URL: https://github.com/apache/lucene-solr-operator/pull/186#discussion_r558630217
##########
File path: README.md
##########
@@ -120,23 +121,15 @@ Have you had a good experience with the **Solr Operator**? Why not share some lo
We welcome issue reports [here](../../issues); be sure to choose the proper issue template for your issue, so that we can be sure you're providing the necessary information.
-Before sending a [Pull Request](../../pulls), please make sure you read our
-[Contribution Guidelines](https://github.com/bloomberg/.github/blob/master/CONTRIBUTING.md).
-
## License
Please read the [LICENSE](LICENSE) file here.
-## Code of Conduct
Review comment:
I was trying to look up something that I thought we used for PR creation in the `lucene-solr` project, just to reuse and be consistent but if I'm unable to find it, this will work :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org