You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/05/13 02:44:03 UTC
Review Request 34134: Add container rootfs to Isolator::prepare().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34134/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
Repository: mesos
Description
-------
Add container rootfs to Isolator::prepare().
Diffs
-----
include/mesos/slave/isolator.hpp b4fe1ffba9ec4e5905f98954bec884a6f5623aeb
src/slave/containerizer/isolator.cpp d99f47e3920c3edf5261d49f1cb77e96df01ab2c
src/slave/containerizer/isolators/cgroups/cpushare.hpp ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5c6e2844fe1a10815956569194b6f56681
src/slave/containerizer/isolators/cgroups/mem.hpp c8e1ba15de399deb9c53c03fbc08e2b2cb514b36
src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2b83cf42f54dbc7ec4c2ba8960b6e194de
src/slave/containerizer/isolators/cgroups/perf_event.hpp 6679719bff24a8fed1aaa62cbef90dfd5a9ee9c0
src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5db654bc1c377b8bd08fa1956bf8cc8110
src/slave/containerizer/isolators/filesystem/shared.hpp 68ed54d8ef9387faa0d968d49f4ebdc5b3e647b4
src/slave/containerizer/isolators/filesystem/shared.cpp 101d6da66e750263fa288b43df2bbf27aaf3adf8
src/slave/containerizer/isolators/namespaces/pid.hpp 187cbe802523973bf28d4e39aa99852e78a9d611
src/slave/containerizer/isolators/namespaces/pid.cpp b426d0806ddf8284a2d9bfe4bb58e6a5e1305ab6
src/slave/containerizer/isolators/posix.hpp 9b43f023708d0d40821da42dc8ec9b046e4b10cc
src/slave/containerizer/isolators/posix/disk.hpp f3f79d8bf83075db06865ea1aca7e8eb3bf872e6
src/slave/containerizer/isolators/posix/disk.cpp caf81e8bc30c0877f4d87c12a0f1073b9553d454
src/slave/containerizer/mesos/containerizer.cpp b644b9c74bc23cf78c0a53284544be6cdaef2f8a
src/tests/containerizer_tests.cpp 3c9f9585f40a6d0d257152932e54d4d12ad067fe
src/tests/isolator.hpp 7db13cdce7226103366e1ff7ca873294017ccead
src/tests/isolator_tests.cpp 24c71b7906a92bdc84a38e88d6084ab09e3cf2ab
Diff: https://reviews.apache.org/r/34134/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 34134: Add container rootfs to Isolator::prepare().
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34134/#review85564
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On May 13, 2015, 12:44 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34134/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 12:44 a.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add container rootfs to Isolator::prepare().
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp b4fe1ffba9ec4e5905f98954bec884a6f5623aeb
> src/slave/containerizer/isolator.cpp d99f47e3920c3edf5261d49f1cb77e96df01ab2c
> src/slave/containerizer/isolators/cgroups/cpushare.hpp ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5c6e2844fe1a10815956569194b6f56681
> src/slave/containerizer/isolators/cgroups/mem.hpp c8e1ba15de399deb9c53c03fbc08e2b2cb514b36
> src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2b83cf42f54dbc7ec4c2ba8960b6e194de
> src/slave/containerizer/isolators/cgroups/perf_event.hpp 6679719bff24a8fed1aaa62cbef90dfd5a9ee9c0
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5db654bc1c377b8bd08fa1956bf8cc8110
> src/slave/containerizer/isolators/filesystem/shared.hpp 68ed54d8ef9387faa0d968d49f4ebdc5b3e647b4
> src/slave/containerizer/isolators/filesystem/shared.cpp 101d6da66e750263fa288b43df2bbf27aaf3adf8
> src/slave/containerizer/isolators/namespaces/pid.hpp 187cbe802523973bf28d4e39aa99852e78a9d611
> src/slave/containerizer/isolators/namespaces/pid.cpp b426d0806ddf8284a2d9bfe4bb58e6a5e1305ab6
> src/slave/containerizer/isolators/posix.hpp 9b43f023708d0d40821da42dc8ec9b046e4b10cc
> src/slave/containerizer/isolators/posix/disk.hpp f3f79d8bf83075db06865ea1aca7e8eb3bf872e6
> src/slave/containerizer/isolators/posix/disk.cpp caf81e8bc30c0877f4d87c12a0f1073b9553d454
> src/slave/containerizer/mesos/containerizer.cpp b644b9c74bc23cf78c0a53284544be6cdaef2f8a
> src/tests/containerizer_tests.cpp 3c9f9585f40a6d0d257152932e54d4d12ad067fe
> src/tests/isolator.hpp 7db13cdce7226103366e1ff7ca873294017ccead
> src/tests/isolator_tests.cpp 24c71b7906a92bdc84a38e88d6084ab09e3cf2ab
>
> Diff: https://reviews.apache.org/r/34134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 34134: Add container rootfs to Isolator::prepare().
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34134/#review84641
-----------------------------------------------------------
LGTM
- Paul Brett
On May 13, 2015, 12:44 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34134/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 12:44 a.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add container rootfs to Isolator::prepare().
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp b4fe1ffba9ec4e5905f98954bec884a6f5623aeb
> src/slave/containerizer/isolator.cpp d99f47e3920c3edf5261d49f1cb77e96df01ab2c
> src/slave/containerizer/isolators/cgroups/cpushare.hpp ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5c6e2844fe1a10815956569194b6f56681
> src/slave/containerizer/isolators/cgroups/mem.hpp c8e1ba15de399deb9c53c03fbc08e2b2cb514b36
> src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2b83cf42f54dbc7ec4c2ba8960b6e194de
> src/slave/containerizer/isolators/cgroups/perf_event.hpp 6679719bff24a8fed1aaa62cbef90dfd5a9ee9c0
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5db654bc1c377b8bd08fa1956bf8cc8110
> src/slave/containerizer/isolators/filesystem/shared.hpp 68ed54d8ef9387faa0d968d49f4ebdc5b3e647b4
> src/slave/containerizer/isolators/filesystem/shared.cpp 101d6da66e750263fa288b43df2bbf27aaf3adf8
> src/slave/containerizer/isolators/namespaces/pid.hpp 187cbe802523973bf28d4e39aa99852e78a9d611
> src/slave/containerizer/isolators/namespaces/pid.cpp b426d0806ddf8284a2d9bfe4bb58e6a5e1305ab6
> src/slave/containerizer/isolators/posix.hpp 9b43f023708d0d40821da42dc8ec9b046e4b10cc
> src/slave/containerizer/isolators/posix/disk.hpp f3f79d8bf83075db06865ea1aca7e8eb3bf872e6
> src/slave/containerizer/isolators/posix/disk.cpp caf81e8bc30c0877f4d87c12a0f1073b9553d454
> src/slave/containerizer/mesos/containerizer.cpp b644b9c74bc23cf78c0a53284544be6cdaef2f8a
> src/tests/containerizer_tests.cpp 3c9f9585f40a6d0d257152932e54d4d12ad067fe
> src/tests/isolator.hpp 7db13cdce7226103366e1ff7ca873294017ccead
> src/tests/isolator_tests.cpp 24c71b7906a92bdc84a38e88d6084ab09e3cf2ab
>
> Diff: https://reviews.apache.org/r/34134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 34134: Add container rootfs to Isolator::prepare().
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34134/#review84772
-----------------------------------------------------------
Ship it!
- Jie Yu
On May 13, 2015, 12:44 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34134/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 12:44 a.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add container rootfs to Isolator::prepare().
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp b4fe1ffba9ec4e5905f98954bec884a6f5623aeb
> src/slave/containerizer/isolator.cpp d99f47e3920c3edf5261d49f1cb77e96df01ab2c
> src/slave/containerizer/isolators/cgroups/cpushare.hpp ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5c6e2844fe1a10815956569194b6f56681
> src/slave/containerizer/isolators/cgroups/mem.hpp c8e1ba15de399deb9c53c03fbc08e2b2cb514b36
> src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2b83cf42f54dbc7ec4c2ba8960b6e194de
> src/slave/containerizer/isolators/cgroups/perf_event.hpp 6679719bff24a8fed1aaa62cbef90dfd5a9ee9c0
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5db654bc1c377b8bd08fa1956bf8cc8110
> src/slave/containerizer/isolators/filesystem/shared.hpp 68ed54d8ef9387faa0d968d49f4ebdc5b3e647b4
> src/slave/containerizer/isolators/filesystem/shared.cpp 101d6da66e750263fa288b43df2bbf27aaf3adf8
> src/slave/containerizer/isolators/namespaces/pid.hpp 187cbe802523973bf28d4e39aa99852e78a9d611
> src/slave/containerizer/isolators/namespaces/pid.cpp b426d0806ddf8284a2d9bfe4bb58e6a5e1305ab6
> src/slave/containerizer/isolators/posix.hpp 9b43f023708d0d40821da42dc8ec9b046e4b10cc
> src/slave/containerizer/isolators/posix/disk.hpp f3f79d8bf83075db06865ea1aca7e8eb3bf872e6
> src/slave/containerizer/isolators/posix/disk.cpp caf81e8bc30c0877f4d87c12a0f1073b9553d454
> src/slave/containerizer/mesos/containerizer.cpp b644b9c74bc23cf78c0a53284544be6cdaef2f8a
> src/tests/containerizer_tests.cpp 3c9f9585f40a6d0d257152932e54d4d12ad067fe
> src/tests/isolator.hpp 7db13cdce7226103366e1ff7ca873294017ccead
> src/tests/isolator_tests.cpp 24c71b7906a92bdc84a38e88d6084ab09e3cf2ab
>
> Diff: https://reviews.apache.org/r/34134/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>