You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/04/13 18:12:22 UTC

[GitHub] [celix] pnoltes commented on a diff in pull request #414: Fix rsalist race

pnoltes commented on code in PR #414:
URL: https://github.com/apache/celix/pull/414#discussion_r849764553


##########
bundles/remote_services/topology_manager/src/topology_manager.c:
##########
@@ -288,6 +289,8 @@ celix_status_t topologyManager_rsaRemoved(void * handle, service_reference_pt re
 	remote_service_admin_service_t *rsa = (remote_service_admin_service_t *) service;
 
 	celixThreadMutex_lock(&manager->rsaListLock);
+	arrayList_removeElement(manager->rsaList, rsa);
+	celixThreadMutex_unlock(&manager->rsaListLock);

Review Comment:
   Yes correct. a single mutex in the topology manager should be enough. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org