You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/10/03 13:27:38 UTC
[GitHub] [cloudstack] GabrielBrascher commented on issue #3615: Handle
Ceph/RBD snapshot delete
GabrielBrascher commented on issue #3615: Handle Ceph/RBD snapshot delete
URL: https://github.com/apache/cloudstack/pull/3615#issuecomment-537945485
@rhtyd I tested the deletion of a ROOT volume snapshot via UI.
Prior to this implementation, the snapshot DB entry was removed; however, the snapshot kept on the RBD. This happened due to the fact that the `StorageSystemSnapshotStrategy` was returning _CANT_HANDLE_, the chosen strategy then was `XenserverSnapshotStrategy`; the XenServer strategy does not consider KVM + Ceph and did removed the snapshot only on DB.
This fix allows the Ceph strategy (wich extends the StorageSystemSnapshotStrategy) to return StrategyPriority.HIGH for deleting snapshots stored on RBD. Therefore, the deleteSnapshot method of `StorageSystemSnapshotStrategy` will be executed and the RBD snapshot removed.
In order to verify, one can delete the snapshot. Assert that it was indeed removed on DB and check if the RBD snapshot was deleted on Ceph (`rbd snap list <volume id on the Ceph storage pool>`).
```
rbd snap list 4324d448-b6e9-468f-b86c-016bbcc702b3
SNAPID NAME SIZE TIMESTAMP
65 5832c1a4-a525-4389-a261-9fdd70b94ca6 205 MiB Fri Sep 27 13:46:13 2019
66 dc3a5fea-4613-4bd6-b2fc-c5ae313ca9c2 205 MiB Fri Sep 27 13:46:23 2019
67 411dbdb3-b250-482b-851e-6d79ffd331d5 205 MiB Fri Sep 27 14:41:32 2019
68 04c5aa37-7f8a-413f-bbb3-1927b34b7f9a 205 MiB Fri Sep 27 14:46:41 2019
69 7f174546-7dff-40d2-aba5-db1a46deda65 205 MiB Fri Sep 27 14:46:49 2019
72 a253ddca-3ea3-4f46-8a80-4b391a2bc2a0 205 MiB Tue Oct 1 04:39:45 2019
81 17da61f7-5a20-4761-9c94-1192053d0aac 205 MiB Wed Oct 2 23:46:39 2019
```
All the snapshots above were removed on DB but not on the Ceph. After applying the fix, I was able to delete snapshots propperly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services