You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2021/04/06 19:36:03 UTC

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison 

sourabhg@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17276


Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................

IMPALA-10637: Fixes bug in ValidWriteIdList comparison

    For a transcational table, catalogD compares previous and current ValidWriteList to determine more recent version out of the two and reloads table cache accordingly. Because of a bug in ValidWriteIdList comparison, catalogD was not populating table cache with more recent changes. As a result of which we were seeing inconsistencies in read after write into the table.

    Tested by
    1. Adding a unit test to compare WriteIDLists.

Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
---
M fe/src/main/java/org/apache/impala/util/AcidUtils.java
M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java
2 files changed, 14 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/17276/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (646) has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 3: Code-Review+1

"Because of a bug in ValidWriteIdList comparison, catalogd was not populating table
cache with more recent changes." 
nit in the commit message : "catalogD was not refreshing table metadata in the cache with more recent changes." . Populating sounds like it's putting the contents for the first time.


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Apr 2021 17:44:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
sourabhg@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 4:

> Patch Set 3: Code-Review+1
> 
> "Because of a bug in ValidWriteIdList comparison, catalogd was not populating table
> cache with more recent changes." 
> nit in the commit message : "catalogD was not refreshing table metadata in the cache with more recent changes." . Populating sounds like it's putting the contents for the first time.

Thanks for the review @kishendas
I have updated the commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Apr 2021 17:56:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG@9
PS1, Line 9:     For a transcational table, catalogD compares previous and current ValidWriteList to determine more recent version out of the two and reloads table cache accordingly. Because of a bug in ValidWriteIdList comparison, catalogD was not populating table cache with more recent changes. As a result of which we were seeing inconsistencies in read after write into the table.
nit: please wrap the commit message lines at 72 chars


http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java
File fe/src/main/java/org/apache/impala/util/AcidUtils.java:

http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java@752
PS1, Line 752:         return Long.signum((a.getInvalidWriteIds()[minLen] - 1) - b.getHighWatermark());
Note that Hive still uses the old version:
https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L70



-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 20:09:35 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8506/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 19:57:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
sourabhg@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 4: Code-Review+1

Carry forwarding +1 from Kishen.


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 00:11:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java
File fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java:

http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java@603
PS1, Line 603:     ValidWriteIdList b = new ValidReaderWriteIdList("default.test:1:9223372036854775807::");
line too long (92 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 19:36:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
sourabhg@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 3:

(2 comments)

Thanks for the review Csaba Ringhofer. I have addressed your comments.

http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG@9
PS1, Line 9: For a transactional table, catalogd compares previous and current ValidWriteList
> nit: please wrap the commit message lines at 72 chars
Sure


http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java
File fe/src/main/java/org/apache/impala/util/AcidUtils.java:

http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java@752
PS1, Line 752:         return Long.signum((a.getInvalidWriteIds()[minLen] - 1) - b.getHighWatermark());
> Note that Hive still uses the old version:
Yes I have filed a jira in Hive as well https://issues.apache.org/jira/browse/HIVE-24975



-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 20:53:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................

IMPALA-10637: Fixes bug in ValidWriteIdList comparison

For a transactional table, catalogd compares previous and current ValidWriteList
to determine more recent version out of the two and reloads table cache accordingly.
Because of a bug in ValidWriteIdList comparison, catalogD was not refreshing table 
metadata in the cache with more recent changes. As a result of which we were seeing 
inconsistencies in read after write into the table.

Tested by
  1. Adding a unit test to compare WriteIDLists.

Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Reviewed-on: http://gerrit.cloudera.org:8080/17276
Reviewed-by: Sourabh Goyal <so...@cloudera.com>
Reviewed-by: Vihang Karajgaonkar <vi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/AcidUtils.java
M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java
2 files changed, 16 insertions(+), 1 deletion(-)

Approvals:
  Sourabh Goyal: Looks good to me, but someone else must approve
  Vihang Karajgaonkar: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 5
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Vihang Karajgaonkar, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17276

to look at the new patch set (#3).

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................

IMPALA-10637: Fixes bug in ValidWriteIdList comparison

For a transactional table, catalogd compares previous and current ValidWriteList
to determine more recent version out of the two and reloads table cache accordingly.
Because of a bug in ValidWriteIdList comparison, catalogd was not populating table
cache with more recent changes. As a result of which we were seeing inconsistencies
in read after write into the table.

Tested by
  1. Adding a unit test to compare WriteIDLists.

Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
---
M fe/src/main/java/org/apache/impala/util/AcidUtils.java
M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/17276/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 4
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 06:08:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Vihang Karajgaonkar, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17276

to look at the new patch set (#2).

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................

IMPALA-10637: Fixes bug in ValidWriteIdList comparison

For a transactional table, catalogd compares previous and current ValidWriteList 
to determine more recent version out of the two and reloads table cache accordingly. 
Because of a bug in ValidWriteIdList comparison, catalogd was not populating table 
cache with more recent changes. As a result of which we were seeing inconsistencies 
in read after write into the table.

Tested by
  1. Adding a unit test to compare WriteIDLists.

Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
---
M fe/src/main/java/org/apache/impala/util/AcidUtils.java
M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java
2 files changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/17276/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 4
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 01:01:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Vihang Karajgaonkar, Anonymous Coward (646), Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17276

to look at the new patch set (#4).

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................

IMPALA-10637: Fixes bug in ValidWriteIdList comparison

For a transactional table, catalogd compares previous and current ValidWriteList
to determine more recent version out of the two and reloads table cache accordingly.
Because of a bug in ValidWriteIdList comparison, catalogD was not refreshing table 
metadata in the cache with more recent changes. As a result of which we were seeing 
inconsistencies in read after write into the table.

Tested by
  1. Adding a unit test to compare WriteIDLists.

Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
---
M fe/src/main/java/org/apache/impala/util/AcidUtils.java
M fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/17276/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8507/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 21:11:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10637: Fixes bug in ValidWriteIdList comparison

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )

Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7052/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Gerrit-Change-Number: 17276
Gerrit-PatchSet: 4
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (646)
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 00:22:40 +0000
Gerrit-HasComments: No