You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by li...@apache.org on 2021/05/12 09:05:57 UTC
[flink] branch release-1.13 updated: [FLINK-22408][sql-parser] Fix
SqlDropPartitions unparse Error
This is an automated email from the ASF dual-hosted git repository.
lirui pushed a commit to branch release-1.13
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.13 by this push:
new 21866fd [FLINK-22408][sql-parser] Fix SqlDropPartitions unparse Error
21866fd is described below
commit 21866fd1b0af732289ea22336c45e1eefcec009e
Author: aidenma <ai...@tencent.com>
AuthorDate: Tue May 11 21:14:36 2021 +0800
[FLINK-22408][sql-parser] Fix SqlDropPartitions unparse Error
This closes #15894
---
.../flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java | 10 +++++++++-
.../org/apache/flink/sql/parser/ddl/SqlDropPartitions.java | 3 +++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java b/flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java
index 0bdf11b..1ff83a0 100644
--- a/flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java
+++ b/flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java
@@ -440,8 +440,16 @@ public class FlinkHiveSqlParserImplTest extends SqlParserTest {
.ok(
"ALTER TABLE `TBL`\n"
+ "DROP\n"
- + "PARTITION (`P1` = 'a', `P2` = 1)\n"
+ + "PARTITION (`P1` = 'a', `P2` = 1),\n"
+ "PARTITION (`P1` = 'b', `P2` = 2)");
+ sql("alter table tbl drop partition (p1='a',p2=1), "
+ + "partition(p1='b',p2=2), partition(p1='c',p2=3)")
+ .ok(
+ "ALTER TABLE `TBL`\n"
+ + "DROP\n"
+ + "PARTITION (`P1` = 'a', `P2` = 1),\n"
+ + "PARTITION (`P1` = 'b', `P2` = 2),\n"
+ + "PARTITION (`P1` = 'c', `P2` = 3)");
// TODO: support IGNORE PROTECTION, PURGE
}
diff --git a/flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDropPartitions.java b/flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDropPartitions.java
index 151e8bd..99d2e6a 100644
--- a/flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDropPartitions.java
+++ b/flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDropPartitions.java
@@ -70,11 +70,14 @@ public class SqlDropPartitions extends SqlAlterTable {
}
int opLeftPrec = getOperator().getLeftPrec();
int opRightPrec = getOperator().getRightPrec();
+ final SqlWriter.Frame frame = writer.startList("", "");
for (SqlNodeList partSpec : partSpecs) {
+ writer.sep(",");
writer.newlineAndIndent();
writer.keyword("PARTITION");
partSpec.unparse(writer, opLeftPrec, opRightPrec);
}
+ writer.endList(frame);
}
@Nonnull